Skip to content

Commit e976a2e

Browse files
authored
chore: fix some comments (apache#1184)
Signed-off-by: sunxunle <sunxunle@gmail.com>
1 parent 2bf93a4 commit e976a2e

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ maintain this crate is limited. Please read the following sections carefully.
151151
### New Syntax
152152

153153
The most commonly accepted PRs add support for or fix a bug in a feature in the
154-
SQL standard, or a a popular RDBMS, such as Microsoft SQL
154+
SQL standard, or a popular RDBMS, such as Microsoft SQL
155155
Server or PostgreSQL, will likely be accepted after a brief
156156
review. Any SQL feature that is dialect specific should be parsed by *both* the relevant [`Dialect`]
157157
as well as [`GenericDialect`].

src/ast/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4649,7 +4649,7 @@ pub struct Function {
46494649
pub args: Vec<FunctionArg>,
46504650
/// e.g. `x > 5` in `COUNT(x) FILTER (WHERE x > 5)`
46514651
pub filter: Option<Box<Expr>>,
4652-
// Snowflake/MSSQL supports diffrent options for null treatment in rank functions
4652+
// Snowflake/MSSQL supports different options for null treatment in rank functions
46534653
pub null_treatment: Option<NullTreatment>,
46544654
pub over: Option<WindowType>,
46554655
// aggregate functions may specify eg `COUNT(DISTINCT x)`

src/dialect/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ macro_rules! dialect_of {
9393
pub trait Dialect: Debug + Any {
9494
/// Determine the [`TypeId`] of this dialect.
9595
///
96-
/// By default, return the same [`TypeId`] as [`Any::type_id`]. Can be overriden
96+
/// By default, return the same [`TypeId`] as [`Any::type_id`]. Can be overridden
9797
/// by dialects that behave like other dialects
9898
/// (for example when wrapping a dialect).
9999
fn dialect(&self) -> TypeId {

tests/sqlparser_sqlite.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ fn pragma_eq_style() {
5555
}
5656
}
5757
#[test]
58-
fn pragma_funciton_style() {
58+
fn pragma_function_style() {
5959
let sql = "PRAGMA cache_size(10)";
6060
match sqlite_and_generic().verified_stmt(sql) {
6161
Statement::Pragma {
@@ -103,7 +103,7 @@ fn pragma_function_string_style() {
103103
}
104104

105105
#[test]
106-
fn pragma_eq_placehoder_style() {
106+
fn pragma_eq_placeholder_style() {
107107
let sql = "PRAGMA table_info = ?";
108108
match sqlite_and_generic().verified_stmt(sql) {
109109
Statement::Pragma {

0 commit comments

Comments
 (0)