ack PR comments

Author: waleed

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/editor/components/sub-block/components/tag-dropdown/components/keyboard-navigation-handler.tsx

@@ -95,7 +95,7 @@ export const KeyboardNavigationHandler: React.FC<KeyboardNavigationHandlerProps>
   useEffect(() => {
     if (!visible || !flatTagList.length) return
 
-    // Helper to open a folder with proper selection callback and child selection
+    // Helper to open a folder with proper selection callback and parent selection
     const openFolderWithSelection = (
       folderId: string,
       folderTitle: string,
@@ -104,20 +104,20 @@ export const KeyboardNavigationHandler: React.FC<KeyboardNavigationHandlerProps>
     ) => {
       const selectionCallback = () => handleTagSelect(parentTag, group)
 
-      // Find first child index
-      let firstChildIndex = 0
+      // Find parent tag index (which is first in visible items when in folder)
+      let parentIndex = 0
       for (const g of nestedBlockTagGroups) {
         for (const nestedTag of g.nestedTags) {
-          if (nestedTag.parentTag === parentTag && nestedTag.children?.[0]) {
-            const idx = flatTagList.findIndex((item) => item.tag === nestedTag.children![0].fullTag)
-            firstChildIndex = idx >= 0 ? idx : 0
+          if (nestedTag.parentTag === parentTag) {
+            const idx = flatTagList.findIndex((item) => item.tag === nestedTag.parentTag)
+            parentIndex = idx >= 0 ? idx : 0
             break
           }
         }
       }
 
       openFolder(folderId, folderTitle, undefined, selectionCallback)
-      setSelectedIndex(firstChildIndex)
+      setSelectedIndex(parentIndex)
     }
 
     const handleKeyboardEvent = (e: KeyboardEvent) => {

apps/sim/components/emcn/components/popover/popover.tsx

@@ -139,7 +139,7 @@ const Popover: React.FC<PopoverProps> = ({ children, variant = 'default', ...pro
     (id: string, title: string, onLoad?: () => void | Promise<void>, onSelect?: () => void) => {
       setCurrentFolder(id)
       setFolderTitle(title)
-      setOnFolderSelect(() => onSelect || null)
+      setOnFolderSelect(onSelect ?? null)
       if (onLoad) {
         void Promise.resolve(onLoad())
       }