Skip to content

Commit c14de14

Browse files
authored
Merge pull request #39 from spdx/npeupgrader
Fix NPE in CompatibilityUpgrader
2 parents c8dd9dd + b33b965 commit c14de14

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/main/java/org/spdx/spdxRdfStore/CompatibilityUpgrader.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ private static void upgradeHasFiles(Model model, String documentNamespace) {
132132
Resource existingRelationship = stmt.getObject().asResource();
133133
Resource relatedElement = existingRelationship.getPropertyResourceValue(model.createProperty(SpdxConstants.SPDX_NAMESPACE + SpdxConstants.PROP_RELATED_SPDX_ELEMENT));
134134
Resource relationshipType = existingRelationship.getPropertyResourceValue(model.createProperty(SpdxConstants.SPDX_NAMESPACE + SpdxConstants.PROP_RELATIONSHIP_TYPE));
135-
if (relatedElement.getURI().equals(file.getURI()) &&
135+
if (relatedElement.isURIResource() && file.isURIResource() && relationshipType.isURIResource() &&
136+
relatedElement.getURI().equals(file.getURI()) &&
136137
relationshipType.getURI().equals(RelationshipType.CONTAINS.getIndividualURI())) {
137138
foundContainsRelationships.add(stmt);
138139
}
@@ -292,7 +293,7 @@ private static void upgradeArtifactOf(Model model, String documentNamespace) thr
292293
statementsToRemove.add(iter.next());
293294
}
294295
Resource pkg = convertDoapProjectToSpdxPackage(model, doapProject, docNamespace + idPrefix + Integer.toString(nextSpdxIdNum));
295-
if (!addedDoapProjects.contains(pkg.getURI())) {
296+
if (pkg.isURIResource() && !addedDoapProjects.contains(pkg.getURI())) {
296297
addedDoapProjects.add(pkg.getURI());
297298
nextSpdxIdNum = getNexId(model, docNamespace, idPrefix, nextSpdxIdNum);
298299
Resource relationship = createRelationship(model, pkg, RelationshipType.GENERATED_FROM);

0 commit comments

Comments
 (0)