Skip to content

Commit cb8ff70

Browse files
fix: java update pre commit (#471)
### Description 1. Use Java 17 for pre-commit 2. pre-publish GS Scorecard message update to more accurate ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done https://github.com/splunk/splunk-dbx-add-on-for-weaviate/actions/runs/22709496276/job/65844449281
1 parent 489d2ed commit cb8ff70

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/reusable-build-test-release.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,10 @@ jobs:
468468
- uses: actions/setup-python@v5
469469
with:
470470
python-version: ${{ env.PYTHON_VERSION }}
471+
- uses: actions/setup-java@v5
472+
with:
473+
distribution: 'temurin'
474+
java-version: '17'
471475
- uses: pre-commit/action@v3.0.1
472476

473477
review_secrets:
@@ -2933,7 +2937,7 @@ jobs:
29332937
# GS Scorecard: must have run for PRs to main (result doesn't matter, but skipped = blocked)
29342938
GS_RESULT=$(echo "$NEEDS" | jq -r '.["run-gs-scorecard"].result')
29352939
if [[ "${{ github.event_name }}" == "pull_request" ]] && [[ "${{ github.base_ref }}" == "main" ]] && [[ "$GS_RESULT" == "skipped" ]]; then
2936-
echo "::error::GS Scorecard is required for PRs to main. Add the 'execute_gs_scorecard' label and re-run the workflow."
2940+
echo "::error::GS Scorecard is required for merging PRs to main. To unblock merging please add the 'execute_gs_scorecard' label and re-run the workflow."
29372941
echo "## GS Scorecard Required" >> "$GITHUB_STEP_SUMMARY"
29382942
echo "Add the \`execute_gs_scorecard\` label to this PR and re-run the workflow. GS Scorecard must complete before merging to main (result does not need to pass)." >> "$GITHUB_STEP_SUMMARY"
29392943
echo "run-publish=false" >> "$GITHUB_OUTPUT"

0 commit comments

Comments
 (0)