More test fixes

Author: andrjohns

tests/testthat/test-fit-mle.R

@@ -53,7 +53,7 @@ test_that("time is reported after optimization", {
 
 test_that("no error when checking estimates after failure", {
   fit <- cmdstanr_example("schools", method = "optimize", seed = 123) # optim ålways fails for this
-  expect_silent(fit$summary(include_failed = TRUE)) # no error
+  expect_error(fit$summary(), "Fitting failed. Unable to retrieve the draws.")
 })
 
 test_that("draws() works for different formats", {

tests/testthat/test-model-compile.R

@@ -278,7 +278,7 @@ test_that("compile() works with pedantic=TRUE", {
   }
   ")
   expect_message(
-    mod_pedantic_warn <- cmdstan_model(stan_file, pedantic = TRUE),
+    mod_pedantic_warn <- cmdstan_model(stan_file, pedantic = TRUE, force_recompile = TRUE),
     "The parameter x was declared but was not used",
     fixed = TRUE
   )
@@ -387,13 +387,10 @@ test_that("check_syntax() works with pedantic=TRUE", {
     fixed = TRUE
   )
 
-  expect_output(
-    expect_message(
-      mod_pedantic_warn$check_syntax(pedantic = TRUE),
-      "The parameter x was declared but was not used",
-      fixed = TRUE
-    ),
-    regexp = NA
+  expect_message(
+    mod_pedantic_warn$check_syntax(pedantic = TRUE),
+    "The parameter x was declared but was not used",
+    fixed = TRUE
   )
 })
 
@@ -706,13 +703,9 @@ test_that("format() works", {
     "target += normal_lpdf(y | 0, 1);",
     fixed = TRUE
   )
-  expect_output(
-    expect_message(
-      mod_1$format(canonicalize = list("includes")),
-      "is deprecated",
-      fixed = TRUE
-    ),
-    "target += normal_log(y, 0, 1);",
+  expect_error(
+    mod_1$format(),
+    "Syntax error found! See the message above for more information.",
     fixed = TRUE
   )