Skip to content

Commit 53795c7

Browse files
committed
nicer name
1 parent c6bcacf commit 53795c7

3 files changed

Lines changed: 4 additions & 17 deletions

File tree

caddy/caddy.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"encoding/json"
88
"errors"
99
"fmt"
10-
"github.com/davecgh/go-spew/spew"
1110
"net/http"
1211
"path/filepath"
1312
"strconv"
@@ -125,8 +124,6 @@ func (f *FrankenPHPApp) Start() error {
125124
return err
126125
}
127126

128-
caddy.Log().Warn(fmt.Sprintf("FrankenPHPApp started with workers: %s", spew.Sdump(append(f.Workers, sharedState.Workers...))))
129-
130127
return nil
131128
}
132129

@@ -465,8 +462,6 @@ func (f *FrankenPHPModule) ServeHTTP(w http.ResponseWriter, r *http.Request, _ c
465462
workerNames[i] = w.Name
466463
}
467464

468-
caddy.Log().Info(fmt.Sprintf("ServeHTTP module has workers: %s", spew.Sdump(f.Workers)))
469-
470465
fr, err := frankenphp.NewRequestWithContext(
471466
r,
472467
documentRootOption,
@@ -632,7 +627,7 @@ func (f *FrankenPHPModule) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
632627
envString += k + "=" + v + ","
633628
}
634629
envString = strings.TrimSuffix(envString, ",")
635-
wc.Name += "env:" + envString + "_"
630+
wc.Name += "env:" + envString + "_" + wc.FileName
636631
}
637632
}
638633
if wc.Name != "" && !strings.HasPrefix(wc.Name, "m#") {
@@ -644,8 +639,6 @@ func (f *FrankenPHPModule) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
644639
}
645640
}
646641

647-
caddy.Log().Warn(fmt.Sprintf("FrankenPHPModule UnmarshalCaddyfile with workers: %s", spew.Sdump(f.Workers)))
648-
649642
return nil
650643
}
651644

frankenphp.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import (
3232
"bytes"
3333
"errors"
3434
"fmt"
35-
"github.com/davecgh/go-spew/spew"
3635
"io"
3736
"net/http"
3837
"os"
@@ -293,8 +292,6 @@ func Init(options ...Option) error {
293292
return err
294293
}
295294

296-
logger.Warn(fmt.Sprintf("FrankenPHP initialised workers: %s", spew.Sdump(opt.workers)))
297-
298295
initAutoScaling(mainThread)
299296

300297
if c := logger.Check(zapcore.InfoLevel, "FrankenPHP started 🐘"); c != nil {
@@ -407,13 +404,10 @@ func ServeHTTP(responseWriter http.ResponseWriter, request *http.Request) error
407404
return nil
408405
}
409406

410-
workerNames := append(fc.workerNames, "")
411-
fc.logger.Warn(fmt.Sprintf("ServeHTTP Worker Names: %s", spew.Sdump(workerNames)))
407+
workerNames := append(fc.workerNames, fc.scriptFilename)
412408
for _, workerName := range workerNames {
413409
// Detect if a worker is available to handle this request
414-
workername := workerName + fc.scriptFilename
415-
if worker := getWorkerForName(workername); worker != nil {
416-
fc.logger.Info(fmt.Sprintf("Found worker: %s", workername))
410+
if worker := getWorkerForName(workerName); worker != nil {
417411
worker.handleRequest(fc)
418412
return nil
419413
}

worker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func newWorker(o workerOpt) (*worker, error) {
8585

8686
key := absFileName
8787
if strings.HasPrefix(o.name, "m#") {
88-
key = o.name + absFileName
88+
key = o.name
8989
}
9090
if wrk := getWorkerForName(key); wrk != nil {
9191
return wrk, nil

0 commit comments

Comments
 (0)