bring error on second global worker with the same filename again

Author: henderkes

phpmainthread_test.go

@@ -32,6 +32,7 @@ func TestStartAndStopTheMainThreadWithOneInactiveThread(t *testing.T) {
 }
 
 func TestTransitionRegularThreadToWorkerThread(t *testing.T) {
+	workers = nil
 	logger = zap.NewNop()
 	_, err := initPHPThreads(1, 1, nil)
 	assert.NoError(t, err)
@@ -56,6 +57,7 @@ func TestTransitionRegularThreadToWorkerThread(t *testing.T) {
 }
 
 func TestTransitionAThreadBetween2DifferentWorkers(t *testing.T) {
+	workers = nil
 	logger = zap.NewNop()
 	_, err := initPHPThreads(1, 1, nil)
 	assert.NoError(t, err)
@@ -156,6 +158,7 @@ func TestAllCommonHeadersAreCorrect(t *testing.T) {
 	}
 }
 func TestFinishBootingAWorkerScript(t *testing.T) {
+	workers = nil
 	logger = zap.NewNop()
 	_, err := initPHPThreads(1, 1, nil)
 	assert.NoError(t, err)

worker.go

@@ -91,7 +91,10 @@ func newWorker(o workerOpt) (*worker, error) {
 	// Check if a worker with the same fileName and moduleID already exists
 	if existingWorkers, ok := workers[absFileName]; ok {
 		for _, existingWorker := range existingWorkers {
-			if existingWorker.moduleID == o.moduleID && o.moduleID != 0 {
+			if existingWorker.moduleID == o.moduleID {
+				if o.moduleID == 0 {
+					return nil, fmt.Errorf("cannot add multiple global workers with the same filename: %s", absFileName)
+				}
 				return existingWorker, nil
 			}
 		}