Skip to content

Commit 0bc365d

Browse files
committed
refactor: remove code for generating ANTLR code
1 parent f5af97f commit 0bc365d

2 files changed

Lines changed: 1 addition & 18 deletions

File tree

CONTRIBUTING.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@ Copy the core function extensions into substrait-python
4545
pixi run copy-extensions
4646
```
4747

48-
## Antlr grammar
49-
50-
Substrait uses antlr grammar to derive output types of extension functions. Make sure java is installed and ANTLR_JAR environment variable is set. Take a look at .devcontainer/Dockerfile for example setup.
51-
52-
```
53-
pixi run antlr
54-
```
55-
5648
## Extensions stubs
5749

5850
Substrait uses jsonschema to describe the data model for extension files.

pyproject.toml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,12 @@ update-substrait = [ { task = "update-submodule" }, { task = "codegen" }]
5959

6060
update-submodule = "./update_submodule.sh"
6161

62-
codegen = [{ task = "antlr" }, { task = "copy-extensions" }, { task = "codegen-extensions" }]
62+
codegen = [{ task = "copy-extensions" }, { task = "codegen-extensions" }]
6363

6464
check-codegen = "./check_codegen.sh"
6565

6666
copy-extensions = "./copy_extension_yamls.sh"
6767

68-
antlr = """
69-
cd third_party/substrait/grammar \
70-
&& antlr4 -o ../../../src/substrait/gen/antlr -Dlanguage=Python3 SubstraitType.g4 \
71-
&& rm ../../../src/substrait/gen/antlr/*.tokens \
72-
&& rm ../../../src/substrait/gen/antlr/*.interp
73-
"""
74-
7568
codegen-extensions = """
7669
datamodel-codegen \
7770
--input-file-type jsonschema \
@@ -84,8 +77,6 @@ codegen-extensions = """
8477
"""
8578

8679
[tool.pixi.dependencies]
87-
antlr = ">=4.13.2,<5"
88-
buf = ">=1.62.1,<2"
8980
datamodel-code-generator = ">=0.52.0,<0.53"
9081
ruff = ">=0.14.10,<0.15"
9182

0 commit comments

Comments
 (0)