Skip to content

Commit cc746b5

Browse files
committed
refactor: remove code for generating ANTLR code
1 parent cff8603 commit cc746b5

2 files changed

Lines changed: 1 addition & 18 deletions

File tree

CONTRIBUTING.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@ Copy the core function extensions into substrait-python
4545
pixi run copy-extensions
4646
```
4747

48-
## Antlr grammar
49-
50-
Substrait uses antlr grammar to derive output types of extension functions. Make sure java is installed and ANTLR_JAR environment variable is set. Take a look at .devcontainer/Dockerfile for example setup.
51-
52-
```
53-
pixi run antlr
54-
```
55-
5648
## Extensions stubs
5749

5850
Substrait uses jsonschema to describe the data model for extension files.

pyproject.toml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,19 +56,12 @@ update-substrait = [ { task = "update-submodule" }, { task = "codegen" }]
5656

5757
update-submodule = "./update_submodule.sh"
5858

59-
codegen = [{ task = "antlr" }, { task = "copy-extensions" }, { task = "codegen-extensions" }]
59+
codegen = [{ task = "copy-extensions" }, { task = "codegen-extensions" }]
6060

6161
check-codegen = "./check_codegen.sh"
6262

6363
copy-extensions = "./copy_extension_yamls.sh"
6464

65-
antlr = """
66-
cd third_party/substrait/grammar \
67-
&& antlr4 -o ../../../src/substrait/gen/antlr -Dlanguage=Python3 SubstraitType.g4 \
68-
&& rm ../../../src/substrait/gen/antlr/*.tokens \
69-
&& rm ../../../src/substrait/gen/antlr/*.interp
70-
"""
71-
7265
codegen-extensions = """
7366
datamodel-codegen \
7467
--input-file-type jsonschema \
@@ -81,7 +74,5 @@ codegen-extensions = """
8174
"""
8275

8376
[tool.pixi.dependencies]
84-
antlr = ">=4.13.2,<5"
85-
buf = ">=1.62.1,<2"
8677
datamodel-code-generator = ">=0.52.0,<0.53"
8778
ruff = ">=0.14.10,<0.15"

0 commit comments

Comments
 (0)