fix(fs): off by one error in readTextFileLines (#3155)

EliasStar · Legend-Master · web-flow · commit 521cd8b372c8 · 2025-12-09T11:48:18.000+08:00
* fix: off by one error in readTextFileLines (#3154) Signed-off-by: EliasStar <31409841+EliasStar@users.noreply.github.com> * Format and regenerate `api-iife.js` --------- Signed-off-by: EliasStar <31409841+EliasStar@users.noreply.github.com> Co-authored-by: Tony <legendmastertony@gmail.com>
diff --git a/.changes/fix-fs-read-text-file-lines-appending-null-byte.md b/.changes/fix-fs-read-text-file-lines-appending-null-byte.md
@@ -0,0 +1,8 @@
+---
+"fs": patch
+"fs-js": patch
+---
+
+Fix off by one error in the implementation of readTextFileLines causing all lines to end with an (additional) null byte.
+Issue: [#3154](https://github.com/tauri-apps/plugins-workspace/issues/3154)
+PR: [#3155](https://github.com/tauri-apps/plugins-workspace/pull/3155)
diff --git a/plugins/fs/api-iife.js b/plugins/fs/api-iife.js
diff --git a/plugins/fs/guest-js/index.ts b/plugins/fs/guest-js/index.ts
@@ -838,7 +838,9 @@ async function readTextFileLines(
         return { value: null, done }
       }
 
-      const line = new TextDecoder().decode(bytes.slice(0, bytes.byteLength))
+      const line = new TextDecoder().decode(
+        bytes.slice(0, bytes.byteLength - 1)
+      )
 
       return {
         value: line,

Original file line number	Diff line number	Diff line change
`@@ -838,7 +838,9 @@ async function readTextFileLines(`
`838`	`838`	`return { value: null, done }`
`839`	`839`	`}`
`840`	`840`
`841`		`- const line = new TextDecoder().decode(bytes.slice(0, bytes.byteLength))`
	`841`	`+ const line = new TextDecoder().decode(`
	`842`	`+ bytes.slice(0, bytes.byteLength - 1)`
	`843`	`+ )`
`842`	`844`
`843`	`845`	`return {`
`844`	`846`	`value: line,`