remove duplicate (and confusing) wait_for method

we had both a `wait_for` and a `wait_for_element` method, one had it’s
own retry, while the other passed that responsibility to the ByClause.

I’ve decided the ByClause is responsible for the behavior here, and
`wait_for_element` seemed too verbose given the element definition are
the required arguments. This also officially makes `wait_for` just a
wrapper around passing the browser to a ByClause.

Author: thisguycodes

ngSe/browser.py

@@ -67,7 +67,9 @@ def quit(self):
                 raise
 
     def wait_for(self, value, by=By.ID):
-        """Waits for an element to appear on screen
+        """Waits for an element according to the passed ByClause
+
+        This is really just a wrapper around passing the browser to a ByClause, allowing for much cleaner syntax.
         """
         # Contract
         must_be(value, "value", basestring)
@@ -239,8 +241,3 @@ def text_is_present(self, text, *args, **kwargs):
     @retry
     def _text_is_present(self, text):
         self.find_element_by_tag_name('body').text.index(text)
-
-    @retry
-    def wait_for_element(self, value, by=By.CSS_SELECTOR):
-        must_be(by, "by", ByClause)
-        return by.wait(value, self)

ngSe/by.py

@@ -51,6 +51,8 @@ class ByClause(object):
     appropriately.
     """
 
+    # TODO[TJ] make methods (convert, wait, find) officially defined as internal-only (prepend with a dunder). This will allow refactoring of how this is used within a browser without breaking 'proper' implimentaions. This may also require some warning to people implimenting custom ByClauses. There's a discussion here.
+
     def __init__(self, by, f):
         # Contract
         must_be(by, "by", basestring)