Make ubuntu 20.04 still available (#2558)

* Make ubuntu 20.04 still available

* Force commands to be run on bash

* bin-packages: drop sudo since it's running in container

* Include build-essential on basesystem.sh

* Improve bin-packages basesystem

* Fix two remaining failing bin-packages build

* Test blindly fixing test.yaml

* Update tests working directory

* Debug test.yaml

* Add docker to basesystem

* Disable zos/pkg which doesn't exists anymore

* Fix latest issue on test.yaml

* Setup docker on qsfs package directly

* bins: drop docker.io from all packages by default

* Apply dependencies check on qsfs

* Fix containerd apt-get prompt

* Fix runs apt-get prompt

Author: maxux

.github/workflows/bin-package-no-tag.yaml

@@ -17,19 +17,20 @@ on:
 jobs:
   builder:
     name: builder
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
+    container: ubuntu:20.04
     steps:
       - name: Checkout code into the Go module directory
         uses: actions/checkout@v1
       - name: Setup basesystem
         run: |
           cd bins
-          sudo -E ./bins-extra.sh --package basesystem
+          ./bins-extra.sh --package basesystem
       - name: Build package (${{ inputs.package }})
         id: package
         run: |
           cd bins
-          sudo -E ./bins-extra.sh --package ${{ inputs.package }}
+          ./bins-extra.sh --package ${{ inputs.package }}
       - name: Publish flist (tf-autobuilder, ${{ steps.package.outputs.name }})
         if: success()
         uses: threefoldtech/publish-flist@master

.github/workflows/bin-package.yaml

@@ -21,7 +21,8 @@ on:
 jobs:
   builder:
     name: builder
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
+    container: ubuntu:20.04
     steps:
       - name: Checkout code into the Go module directory
         uses: actions/checkout@v1
@@ -32,6 +33,7 @@ jobs:
       # and then accessed later in the workflow
       - name: Set tag of build
         id: tag
+        shell: bash
         run: |
           ref="${{ github.ref }}"
           if [ "${{ github.ref_type }}" = "tag" ]; then
@@ -41,14 +43,16 @@ jobs:
             echo "reference=${reference:0:7}" >> $GITHUB_OUTPUT
           fi
       - name: Setup basesystem
+        shell: bash
         run: |
           cd bins
-          sudo -E ./bins-extra.sh --package basesystem
+          ./bins-extra.sh --package basesystem
       - name: Build package (${{ inputs.package }})
         id: package
+        shell: bash
         run: |
           cd bins
-          sudo -E ./bins-extra.sh --package ${{ inputs.package }}
+          ./bins-extra.sh --package ${{ inputs.package }}
       - name: Publish flist (tf-autobuilder, ${{ steps.package.outputs.name }})
         if: success()
         uses: threefoldtech/publish-flist@master

.github/workflows/test.yaml

@@ -18,21 +18,21 @@ jobs:
           sudo apt-get install -y libjansson-dev libhiredis-dev
 
       - name: Checkout code into the Go module directory
-        uses: actions/checkout@v1
+        uses: actions/checkout@v4
 
-      - name: Get dependencies
-        run: |
-          cd pkg
-          make getdeps
-        env:
-          GO111MODULE: on
+      # - name: Get dependencies
+      #   run: |
+      #     cd zos/pkg
+      #     make getdeps
+      #   env:
+      #     GO111MODULE: on
 
-      - name: Run tests
-        run: |
-          cd pkg
-          make testrace
-        env:
-          GO111MODULE: on
+      # - name: Run tests
+      #   run: |
+      #     cd zos/pkg
+      #     make testrace
+      #   env:
+      #     GO111MODULE: on
 
       - name: Build binaries
         run: |

bins/packages/basesystem/basesystem.sh

@@ -1,5 +1,5 @@
 build_basesystem() {
     apt-get update
-    apt-get install -y curl wget
+    apt-get install -y curl wget build-essential autoconf unzip
 }
 

bins/packages/containerd/containerd.sh

@@ -3,6 +3,10 @@ CONTAINERD_CHECKSUM="1ac525600fe7ba6ef76cf8a833153768"
 CONTAINERD_LINK="https://github.com/containerd/containerd/archive/refs/tags/v${CONTAINERD_VERSION}.tar.gz"
 
 dependencies_containerd() {
+    export DEBIAN_FRONTEND=noninteractive 
+    export DEBCONF_NONINTERACTIVE_SEEN=true
+
+
     apt-get install -y btrfs-progs libbtrfs-dev libseccomp-dev build-essential pkg-config
 
     if [ -z $GOPATH ] || [ ! -z $CI ]; then

bins/packages/qsfs/qsfs.sh

@@ -1,6 +1,11 @@
 QSFS_VERSION="0.2.0-rc2"
 QSFS_IMAGE="ghcr.io/threefoldtech/qsfs"
 
+ensure_dependencies() {
+    apt-get update
+    apt-get install -y docker.io
+}
+
 download_qsfs() {
     echo "download qsfs"
     download_docker_image ${QSFS_IMAGE}:${QSFS_VERSION} qsfs-${QSFS_VERSION}.tar
@@ -22,6 +27,7 @@ install_qsfs() {
 build_qsfs() {
     pushd "${DISTDIR}"
 
+    ensure_dependencies
     download_qsfs
     popd
 

bins/packages/runc/runc.sh

@@ -3,6 +3,9 @@ RUNC_CHECKSUM="ae8e2ac9335b8606eeccd2e7c031350a"
 RUNC_LINK="https://github.com/opencontainers/runc/archive/refs/tags/v${RUNC_VERSION}.tar.gz"
 
 dependencies_runc() {
+    export DEBIAN_FRONTEND=noninteractive 
+    export DEBCONF_NONINTERACTIVE_SEEN=true
+    
     apt-get install -y btrfs-progs libbtrfs-dev libseccomp-dev build-essential pkg-config
 
     if [ -z $GOPATH ] || [ ! -z $CI ]; then