allow relay update when changed

Author: Eslam-Nawara

cmds/modules/api_gateway/main.go

@@ -111,7 +111,7 @@ func action(cli *cli.Context) error {
 	bo := backoff.NewExponentialBackOff()
 	bo.MaxElapsedTime = 0
 
-    // this peer is used to allow the node to restart the peer without the need to cancel the module context
+	// this ctx is used to allow the node to restart the peer without leaving any unwanted open connections
 	peerCtx, cancel := context.WithCancel(ctx)
 	defer cancel()
 
@@ -144,11 +144,7 @@ func action(cli *cli.Context) error {
 			return nil
 			// check if we need to run an update on the peer and only do the update if all the changes are done successfully
 		case <-time.After(10 * time.Minute):
-			// if we can get time from substrate then we don't need to update the connection
-			if _, err := gw.GetTime(); err == nil {
-				continue
-			}
-
+			log.Debug().Msg("checking for updates in zos config")
 			env, err := environment.Get()
 			if err != nil {
 				// skip update if we can't get env
@@ -165,11 +161,19 @@ func action(cli *cli.Context) error {
 			slices.Sort(updatedSubURLs)
 			slices.Sort(updatedRelayURLs)
 
-			// skip update if the urls did not change
+			// skip update if substrate and relay urls did not change
 			if slices.Equal(subURLs, updatedSubURLs) && slices.Equal(relayURLs, updatedRelayURLs) {
 				continue
 			}
 
+			// skip update if the old substrate connection is working fine
+			if !slices.Equal(subURLs, updatedSubURLs) {
+				if _, err := gw.GetTime(); err == nil {
+					log.Debug().Msg("the open connection is already working, no update needed")
+					continue
+				}
+			}
+
 			newPeerCtx, newCancel := context.WithCancel(ctx)
 			if err := updatePeer(newPeerCtx, updatedSubURLs, updatedRelayURLs, pair.Seed(), router.Serve); err != nil {
 				log.Debug().Err(err).Send()

cmds/modules/noded/main.go

@@ -252,9 +252,11 @@ func action(cli *cli.Context) error {
 		for {
 			<-time.After(10 * time.Minute)
 
+			log.Debug().Msg("checking for updates in zos config")
 			cl, _, err := sub.Raw()
 			if err == nil {
 				// skip update if the connection is working properly
+				log.Debug().Msg("the open connection is working, no update needed")
 				cl.Client.Close()
 				continue
 			}