check on errors length of all healthchecks (#2352)

* recessively check on errors length of all healthchecks

* check the result type assertion

* use redis.Bytes instead of asserting result to []byte

Author: Omarabdul3ziz

pkg/diagnostics/diagnostics.go

@@ -8,7 +8,6 @@ import (
 
 	"github.com/gomodule/redigo/redis"
 	"github.com/threefoldtech/zbus"
-	"github.com/threefoldtech/zos/pkg"
 	"github.com/threefoldtech/zos/pkg/utils"
 )
 
@@ -119,19 +118,24 @@ func (m *DiagnosticsManager) isHealthy() bool {
 	conn := m.redisPool.Get()
 	defer conn.Close()
 
-	data, err := conn.Do("GET", testNetworkKey)
+	data, err := redis.Bytes(conn.Do("GET", testNetworkKey))
 	if err != nil || data == nil {
 		return false
 	}
 
-	var result pkg.TaskResult
-	if err := json.Unmarshal(data.([]byte), &result); err != nil {
-		return false
+	var result struct {
+		Result map[string][]string `json:"result"`
 	}
 
-	if len(result.Result.(map[string]interface{})) != 0 {
+	if err := json.Unmarshal(data, &result); err != nil {
 		return false
 	}
 
+	for _, errors := range result.Result {
+		if len(errors) > 0 {
+			return false
+		}
+	}
+
 	return true
 }