Code review:

- moving responsibility of deducing co-author to repo
- added co-author inside commit

Author: fpozzobon

src/mkdocs_git_authors_plugin/git/commit.py

@@ -1,5 +1,5 @@
 import re
-from typing import Union
+from typing import Any, Union
 
 from mkdocs_git_authors_plugin import util
 from mkdocs_git_authors_plugin.git.repo import AbstractRepoObject, Repo
@@ -24,6 +24,7 @@ def __init__(
         author_time: str,
         author_tz: str,
         summary: str,
+        co_authors: list[Any],
     ):
         """Initialize a commit from its SHA.
 
@@ -48,6 +49,7 @@ def __init__(
         self._datetime = util.commit_datetime(author_time, author_tz)
         self._datetime_string = util.commit_datetime_string(self._datetime)
         self._summary = summary
+        self._co_authors = co_authors
 
     def author(self):
         """
@@ -60,6 +62,17 @@ def author(self):
         """
         return self._author
 
+    def co_authors(self):
+        """
+        The commit's co-author.
+
+        Args:
+
+        Returns:
+            Co-Authors list
+        """
+        return self._co_authors
+
     def datetime(self, _type=str) -> Union[str, util.datetime]:
         """
         The commit's commit time.

src/mkdocs_git_authors_plugin/git/page.py

@@ -32,8 +32,6 @@ def __init__(self, repo: Repo, path: Path, strict: bool) -> None:
         self._total_lines = 0
         self._authors: List[dict] = list()
         self._strict = strict
-        # Cache Logs, indexed by 40 char SHA
-        self._cached_logs = {}
 
         try:
             self._process_git_blame()
@@ -200,85 +198,11 @@ def _process_git_blame(self) -> None:
                         self.add_total_lines()
                         self.repo().add_total_lines()
                     # Process co-authors if present
-                    self._process_git_log(commit_data.get("sha"), commit)
-
-    def _process_git_log(self, sha, commit) -> None:
-        """
-        Execute git log and parse the results.
-
-        This retrieves [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors) from comment.
-        Each line will be associated with a Commit object and counted
-        to its co-author's "account".
-        Whether empty lines are counted is determined by the
-        count_empty_lines configuration option.
-
-        git log -1 <sha> will produce output like the following
-        for each line in a file:
-
-        When a commit does not contain co-authors:
-            commit ca8b32b24af1ce97fb29c5139b2f80e0c2ad9d1c
-            Author: John Doe <jdoe@john.com>
-            Date:   Sun Dec 22 11:10:32 2019 +0100
-
-                add plugin skeleton
-
-        When a commit contains co-authors:
-            commit ca8b32b24af1ce97fb29c5139b2f80e0c2ad9d1c
-            Author: John Doe <jdoe@john.com>
-            Date:   Sun Dec 22 11:10:32 2019 +0100
-
-                add plugin skeleton
-
-                Co-authored-by: John Doe <jdoe@john.com>
-                Co-authored-by: Rock Smith <rsmith@smith.com>
-
-        In this case we skip the original author as redundant using email address to detect it.
-
-        Args:
-            sha: the SHA of the commit to process
-        Returns:
-            --- (this method works through side effects)
-        """
-
-        co_authors = self._get_git_log(sha, commit)
-        for co_author in co_authors:
-            # Create the co-author
-            if co_author not in self._authors:
-                self._authors.append(co_author)
-            co_author.add_lines(self, commit)
-
-    def _get_git_log(self, sha, commit):
-        if self._cached_logs.get(sha) is None:
-            args = ["-1", sha]
-            cmd = GitCommand("log", args)
-            cmd.run()
-
-            lines = cmd.stdout()
-
-            # in case of empty, non-committed files, raise error
-            if len(lines) == 0:
-                raise GitCommandError
-            self._cached_logs[sha] = self._parse_git_log(lines, commit)
-        return self._cached_logs.get(sha)
-
-    def _parse_git_log(self, lines, commit):
-        parsed_logs = []
-        ignore_authors = self.repo().config("ignore_authors")
-        for line in lines:
-            if line.startswith("Author: "):
-                # skip author as already available in Commit object
-                continue
-
-            result = re.search(r"Co-authored-by: (.*) <(.*)>", line)
-            if result is not None and result.group(1) != "" and result.group(2) != "":
-                # Extract co-authors from the commit
-                co_author = self.repo().author(result.group(1), result.group(2))
-                if (
-                    co_author.email() not in ignore_authors
-                    and co_author.email() != commit.author().email()
-                ):
-                    parsed_logs.append(co_author)
-        return parsed_logs
+                    for co_author in commit.co_authors():
+                        # Create the co-author
+                        if co_author not in self._authors:
+                            self._authors.append(co_author)
+                        co_author.add_lines(self, commit)
 
     def path(self) -> Path:
         """

src/mkdocs_git_authors_plugin/git/repo.py

@@ -1,8 +1,11 @@
+import re
 from pathlib import Path
 from typing import Any, Union
 
 from mkdocs_git_authors_plugin.git.command import GitCommand
 
+from mkdocs_git_authors_plugin.git.command import GitCommandError
+
 
 class Repo(object):
     """
@@ -113,9 +116,76 @@ def get_commit(self, sha: str, **kwargs) -> Union[Any, None]:
         if not self._commits.get(sha):
             from .commit import Commit
 
+            kwargs["co_authors"] = self._get_co_authors(sha, kwargs.get("author_email"))
             self._commits[sha] = Commit(self, sha, **kwargs)
         return self._commits.get(sha)
 
+    def _get_co_authors(self, sha, author_email) -> list[Any]:
+        """
+        Execute git log and parse the results.
+
+        This retrieves [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors) from comment.
+        Each line will be associated with a Commit object and counted
+        to its co-author's "account".
+        Whether empty lines are counted is determined by the
+        count_empty_lines configuration option.
+
+        git log -1 <sha> will produce output like the following
+        for each line in a file:
+
+        When a commit does not contain co-authors:
+            commit ca8b32b24af1ce97fb29c5139b2f80e0c2ad9d1c
+            Author: John Doe <jdoe@john.com>
+            Date:   Sun Dec 22 11:10:32 2019 +0100
+
+                add plugin skeleton
+
+        When a commit contains co-authors:
+            commit ca8b32b24af1ce97fb29c5139b2f80e0c2ad9d1c
+            Author: John Doe <jdoe@john.com>
+            Date:   Sun Dec 22 11:10:32 2019 +0100
+
+                add plugin skeleton
+
+                Co-authored-by: John Doe <jdoe@john.com>
+                Co-authored-by: Rock Smith <rsmith@smith.com>
+
+        In this case we skip the original author as redundant using email address to detect it.
+
+        Args:
+            sha: the SHA of the commit to process
+            author_email: email of the author
+        Returns:
+            List of co-authors excluding commit author
+        """
+        args = ["-1", sha]
+        cmd = GitCommand("log", args)
+        cmd.run()
+
+        lines = cmd.stdout()
+
+        # in case of empty, non-committed files, raise error
+        if len(lines) == 0:
+            raise GitCommandError
+        co_authors = []
+        ignore_authors = self.config("ignore_authors")
+
+        for line in lines:
+            if line.startswith("Author: "):
+                # skip author as already available in Commit object
+                continue
+
+            result = re.search(r"Co-authored-by: (.*) <(.*)>", line)
+            if result is not None and result.group(1) != "" and result.group(2) != "":
+                # Extract co-authors from the commit
+                co_author = self.author(result.group(1), result.group(2))
+                if (
+                    co_author.email() not in ignore_authors
+                    and co_author.email() != author_email
+                ):
+                    co_authors.append(co_author)
+        return co_authors
+
     def page(self, path):
         """
         Return the (cached) Page object for given path.