Change sending notification to fire-and-forget

Author: tpeczek

Demo.AspNetCore.PushNotifications.Services.Abstractions/IPushNotificationService.cs

@@ -1,11 +1,12 @@
-using Lib.Net.Http.WebPush;
+using System.Threading.Tasks;
+using Lib.Net.Http.WebPush;
 
 namespace Demo.AspNetCore.PushNotifications.Services.Abstractions
 {
     public interface IPushNotificationService
     {
         string PublicKey { get; }
 
-        void SendNotification(PushSubscription subscription, PushMessage message);
+        Task SendNotificationAsync(PushSubscription subscription, PushMessage message);
     }
 }

Demo.AspNetCore.PushNotifications.Services.PushService/PushServicePushNotificationService.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Threading.Tasks;
 using Microsoft.Extensions.Options;
 using Microsoft.Extensions.Logging;
 using Lib.Net.Http.WebPush;
@@ -32,11 +33,11 @@ public PushServicePushNotificationService(IOptions<PushNotificationServiceOption
             _logger = logger;
         }
 
-        public void SendNotification(PushSubscription subscription, PushMessage message)
+        public async Task SendNotificationAsync(PushSubscription subscription, PushMessage message)
         {
             try
             {
-                _pushClient.RequestPushMessageDeliveryAsync(subscription, message).Wait();
+                await _pushClient.RequestPushMessageDeliveryAsync(subscription, message);
             }
             catch (Exception ex)
             {

Demo.AspNetCore.PushNotifications/Controllers/PushNotificationsApiController.cs

@@ -54,7 +54,11 @@ public async Task<IActionResult> SendNotification([FromBody]PushMessageViewModel
             };
 
             // TODO: This should be scheduled in background
-            await _subscriptionStore.ForEachSubscriptionAsync((PushSubscription subscription) => _notificationService.SendNotification(subscription, pushMessage));
+            await _subscriptionStore.ForEachSubscriptionAsync((PushSubscription subscription) =>
+            {
+                // Fire-and-forget 
+                _notificationService.SendNotificationAsync(subscription, pushMessage);
+            });
 
             return NoContent();
         }