bulletins shouldnt know about timezones

Author: sethphillips

Tests/BulletinTest.php

@@ -142,10 +142,10 @@ function test_the_on_off_and_cycle_times_default_to_a_reasonable_value()
 
     $bulletin = new Bulletin;
 
-    $this->assertEquals($thisMorning->format(\DateTime::W3C), $bulletin->DateTimeOn);
-    $this->assertEquals($tonight->format(\DateTime::W3C), $bulletin->DateTimeOff);
-    $this->assertEquals($thisMorning->format(\DateTime::W3C), $bulletin->CycleTimeOn);
-    $this->assertEquals($tonight->format(\DateTime::W3C), $bulletin->CycleTimeOff);
+    $this->assertEquals($thisMorning->format('Y-m-d\TH:i:s'), $bulletin->DateTimeOn);
+    $this->assertEquals($tonight->format('Y-m-d\TH:i:s'), $bulletin->DateTimeOff);
+    $this->assertEquals($thisMorning->format('Y-m-d\TH:i:s'), $bulletin->CycleTimeOn);
+    $this->assertEquals($tonight->format('Y-m-d\TH:i:s'), $bulletin->CycleTimeOff);
   }
 
   function test_you_can_set_the_bulletins_display_times_individually()
@@ -158,8 +158,8 @@ function test_you_can_set_the_bulletins_display_times_individually()
       ->setDateTimeOn($now)
       ->setDateTimeOff($tomorrow);
 
-    $this->assertEquals($now->format(\DateTime::W3C), $bulletin->DateTimeOn);
-    $this->assertEquals($tomorrow->format(\DateTime::W3C), $bulletin->DateTimeOff);
+    $this->assertEquals($now->format('Y-m-d\TH:i:s'), $bulletin->DateTimeOn);
+    $this->assertEquals($tomorrow->format('Y-m-d\TH:i:s'), $bulletin->DateTimeOff);
   }
 
   function test_you_can_set_the_bulletins_display_times_together_as_a_set()
@@ -174,8 +174,8 @@ function test_you_can_set_the_bulletins_display_times_together_as_a_set()
       ->setSchedule($now,$tomorrow);
 
     $this->assertTrue($bulletin->IsScheduled);
-    $this->assertEquals($now->format(\DateTime::W3C), $bulletin->DateTimeOn);
-    $this->assertEquals($tomorrow->format(\DateTime::W3C), $bulletin->DateTimeOff);
+    $this->assertEquals($now->format('Y-m-d\TH:i:s'), $bulletin->DateTimeOn);
+    $this->assertEquals($tomorrow->format('Y-m-d\TH:i:s'), $bulletin->DateTimeOff);
   }
 
   function test_you_can_set_the_bulletins_cycle_times_individually()
@@ -189,8 +189,8 @@ function test_you_can_set_the_bulletins_cycle_times_individually()
       ->setCycleTimeOn($on)
       ->setCycleTimeOff($off);
 
-    $this->assertEquals($on->setTime(11,00,00)->format(\DateTime::W3C), $bulletin->CycleTimeOn);
-    $this->assertEquals($off->setTime(14,00,00)->format(\DateTime::W3C), $bulletin->CycleTimeOff);
+    $this->assertEquals($on->setTime(11,00,00)->format('Y-m-d\TH:i:s'), $bulletin->CycleTimeOn);
+    $this->assertEquals($off->setTime(14,00,00)->format('Y-m-d\TH:i:s'), $bulletin->CycleTimeOff);
   }
 
   function test_you_can_set_the_bulletins_cycle_times_together_as_a_set()
@@ -203,8 +203,8 @@ function test_you_can_set_the_bulletins_cycle_times_together_as_a_set()
     $bulletin
       ->setCycleTimes($on, $off);
 
-    $this->assertEquals($on->setTime(11,00,00)->format(\DateTime::W3C), $bulletin->CycleTimeOn);
-    $this->assertEquals($off->setTime(14,00,00)->format(\DateTime::W3C), $bulletin->CycleTimeOff);
+    $this->assertEquals($on->setTime(11,00,00)->format('Y-m-d\TH:i:s'), $bulletin->CycleTimeOn);
+    $this->assertEquals($off->setTime(14,00,00)->format('Y-m-d\TH:i:s'), $bulletin->CycleTimeOff);
   }
 
   function test_you_can_turn_all_days_on_and_off()

src/Models/Bulletin.php

@@ -104,15 +104,15 @@ public function getGroup()
   public function resetSchedule()
   {
     $this->IsScheduled = false;
-    $this->DateTimeOn = Carbon::now()->setTime(0,0,0)->format(DateTime::W3C);
-    $this->DateTimeOff = Carbon::now()->setTime(23,59,59)->format(DateTime::W3C);
+    $this->DateTimeOn = Carbon::now()->setTime(0,0,0)->format('Y-m-d\TH:i:s');
+    $this->DateTimeOff = Carbon::now()->setTime(23,59,59)->format('Y-m-d\TH:i:s');
     return $this;
   }
 
   public function resetCycleTimes()
   {
-    $this->CycleTimeOn = Carbon::now()->setTime(0,0,0)->format(DateTime::W3C);
-    $this->CycleTimeOff = Carbon::now()->setTime(23,59,59)->format(DateTime::W3C);
+    $this->CycleTimeOn = Carbon::now()->setTime(0,0,0)->format('Y-m-d\TH:i:s');
+    $this->CycleTimeOff = Carbon::now()->setTime(23,59,59)->format('Y-m-d\TH:i:s');
     return $this;
   }
 
@@ -256,37 +256,37 @@ private function arrayToBitField(Array $array)
   public function setSchedule(DateTime $on, DateTime $off)
   {
     $this->IsScheduled = true;
-    $this->DateTimeOn = $on->format(DateTime::W3C);
-    $this->DateTimeOff = $off->format(DateTime::W3C);
+    $this->DateTimeOn = $on->format('Y-m-d\TH:i:s');
+    $this->DateTimeOff = $off->format('Y-m-d\TH:i:s');
     return $this;
   }
   public function setDateTimeOn(DateTime $on)
   {
-    $this->DateTimeOn = $on->format(DateTime::W3C);
+    $this->DateTimeOn = $on->format('Y-m-d\TH:i:s');
     return $this;
   }
 
   public function setDateTimeOff(DateTime $off)
   {
-    $this->DateTimeOff = $off->format(DateTime::W3C);
+    $this->DateTimeOff = $off->format('Y-m-d\TH:i:s');
     return $this;
   }
 
-  public function setCycleTimes(DateTime$on, DateTime$off)
+  public function setCycleTimes(DateTime $on, DateTime $off)
   {
-    $this->CycleTimeOn = $on->format(DateTime::W3C);
-    $this->CycleTimeOff = $off->format(DateTime::W3C);
+    $this->CycleTimeOn = $on->format('Y-m-d\TH:i:s');
+    $this->CycleTimeOff = $off->format('Y-m-d\TH:i:s');
     return $this;
   }
 
   public function setCycleTimeOn(DateTime $on)
   {
-    $this->CycleTimeOn = $on->format(DateTime::W3C);
+    $this->CycleTimeOn = $on->format('Y-m-d\TH:i:s');
     return $this;
   }
   public function setCycleTimeOff(DateTime $off)
   {
-    $this->CycleTimeOff = $off->format(DateTime::W3C);
+    $this->CycleTimeOff = $off->format('Y-m-d\TH:i:s');
     return $this;
   }