cc userver: enable bugprone-use-after-move clang-tidy check

Tests: CI
commit_hash:5e83f7eaedbf0e32509d271648e26edc89000b4a

Author: TTPO100AJIEX

.clang-tidy

@@ -21,7 +21,6 @@ Checks:
   ,-bugprone-implicit-widening-of-multiplication-result\
   ,-bugprone-lambda-function-name\
   ,-bugprone-narrowing-conversions\
-  ,-bugprone-use-after-move\
   ,-cert-dcl21-cpp\
   ,-cert-err09-cpp\
   ,-cert-err33-c\

.mapping.json

@@ -5514,6 +5514,7 @@
   "universal/include/userver/utils/fixed_array.hpp":"taxi/uservices/userver/universal/include/userver/utils/fixed_array.hpp",
   "universal/include/userver/utils/flags.hpp":"taxi/uservices/userver/universal/include/userver/utils/flags.hpp",
   "universal/include/userver/utils/fmt_compat.hpp":"taxi/uservices/userver/universal/include/userver/utils/fmt_compat.hpp",
+  "universal/include/userver/utils/forward_like.hpp":"taxi/uservices/userver/universal/include/userver/utils/forward_like.hpp",
   "universal/include/userver/utils/from_string.hpp":"taxi/uservices/userver/universal/include/userver/utils/from_string.hpp",
   "universal/include/userver/utils/function_ref.hpp":"taxi/uservices/userver/universal/include/userver/utils/function_ref.hpp",
   "universal/include/userver/utils/get_if.hpp":"taxi/uservices/userver/universal/include/userver/utils/get_if.hpp",

core/functional_tests/websocket/service.cpp

@@ -46,7 +46,7 @@ class WebsocketsHandler final : public server::handlers::WebsocketHandlerBase {
                 break;
             }
 
-            chat.Send(std::move(message));
+            chat.Send(message);
         }
         if (message.close_status) {
             chat.Close(*message.close_status);
@@ -74,7 +74,7 @@ class WebsocketsHandlerAlt final : public server::handlers::WebsocketHandlerBase
                 if (message.close_status) {
                     break;
                 }
-                chat.Send(std::move(message));
+                chat.Send(message);
             } else {
                 // we could've sent yet another server::websocket::Message
                 // e.g. chat.SendBinary(server::websocket::Message{ "blah", {}, true });

core/include/userver/concurrent/impl/monotonic_concurrent_set.hpp

@@ -467,6 +467,8 @@ std::pair<T&, bool> MonotonicConcurrentSet<T, Hash, KeyEqual>::TryEmplace(const
                 continue;
             }
 
+            // Value of 'args' is only consumed if item construction happens.
+            // NOLINTNEXTLINE(bugprone-use-after-move)
             auto [item, inserted] = TryEmplaceLocked(current, bucket, key, std::forward<Args>(args)...);
 
             if (item) {

core/src/clients/http/request.cpp

@@ -253,6 +253,7 @@ Request& Request::url(std::string url) & {
 
     /// `curl::easy::set_url(std::string&&, std::error_code&)` doesn't consume the string if fails.
     if (ec) {
+        // NOLINTNEXTLINE(bugprone-use-after-move)
         throw BadArgumentException(ec, "Bad URL", url, {});
     }
 

core/src/components/component_list.cpp

@@ -41,10 +41,11 @@ yaml_config::Schema ComponentList::GetStaticConfigSchema() const {
 }
 
 ComponentList& ComponentList::Append(impl::ComponentAdderPtr&& added) & {
+    const auto component_name = added->GetComponentName();
     auto [it, ok] = adders_.insert(std::move(added));
     if (!ok) {
         // Append is typically called from main(), throwing an exception would std::terminate.
-        utils::AbortWithStacktrace(fmt::format("Attempt to add a duplicate component '{}'", added->GetComponentName()));
+        utils::AbortWithStacktrace(fmt::format("Attempt to add a duplicate component '{}'", component_name));
     }
     return *this;
 }

core/src/concurrent/mp_queue_test.hpp

@@ -246,6 +246,7 @@ TYPED_UTEST_P(TypedQueueFixture, Noblock) {
 
         auto value = this->Wrap(2);
         EXPECT_FALSE(producer.PushNoblock(std::move(value)));
+        // NOLINTNEXTLINE(bugprone-use-after-move)
         EXPECT_TRUE(this->CheckWasNotMovedOut(value));
     }
 
@@ -264,10 +265,12 @@ TYPED_UTEST_P(TypedQueueFixture, NotMovedValueOnFalse) {
 
     auto value = this->Wrap(2);
     EXPECT_FALSE(producer.PushNoblock(std::move(value)));
+    // NOLINTNEXTLINE(bugprone-use-after-move)
     EXPECT_TRUE(this->CheckWasNotMovedOut(value));
 
     engine::current_task::GetCancellationToken().RequestCancel();
     EXPECT_FALSE(producer.Push(std::move(value)));
+    // NOLINTNEXTLINE(bugprone-use-after-move)
     EXPECT_TRUE(this->CheckWasNotMovedOut(value));
 }
 

core/src/curl-ev/easy.cpp

@@ -601,6 +601,7 @@ void easy::add_resolve(const std::string& host, const std::string& port, const s
             std::move(host_port_addr)
         ))
     {
+        // NOLINTNEXTLINE(bugprone-use-after-move)
         UASSERT_MSG(!host_port_addr.empty(), "ReplaceFirstIf moved the string out, when it shouldn't have done so.");
         resolved_hosts_->add(std::move(host_port_addr));
     }

core/src/curl-ev/string_list_test.cpp

@@ -85,6 +85,7 @@ TEST(CurlStringList, ReplaceFirstIfOnlyConsumesOnReplacement) {
         const auto replaced = list.ReplaceFirstIf([](const std::string&) { return false; }, std::move(value));
         EXPECT_FALSE(replaced);
         // value is not moved out
+        // NOLINTNEXTLINE(bugprone-use-after-move)
         EXPECT_FALSE(value.empty());
     }
 
@@ -93,6 +94,7 @@ TEST(CurlStringList, ReplaceFirstIfOnlyConsumesOnReplacement) {
         const auto replaced = list.ReplaceFirstIf([](const std::string&) { return true; }, std::move(value));
         EXPECT_TRUE(replaced);
         // now value is moved out
+        // NOLINTNEXTLINE(bugprone-use-after-move)
         EXPECT_TRUE(value.empty());
     }
 }

core/src/engine/ev/thread_pool.cpp

@@ -19,7 +19,7 @@ ThreadPool::ThreadPool(ThreadPoolConfig config, UseDefaultEvLoop)
     : ThreadPool(std::move(config), !config.ev_default_loop_disabled)
 {}
 
-ThreadPool::ThreadPool(ThreadPoolConfig config, bool use_ev_default_loop)
+ThreadPool::ThreadPool(ThreadPoolConfig&& config, bool use_ev_default_loop)
     : use_ev_default_loop_(use_ev_default_loop)
 {
     threads_ = utils::GenerateFixedArray(config.threads, [&](std::size_t index) {