Skip to content

Commit 79bbb3d

Browse files
committed
fix build: account for not having parsing for std::chrono::year_month_day (take 2)
commit_hash:fbe178822a7e6e83294d4698ee868521183374b5
1 parent 836045c commit 79bbb3d

1 file changed

Lines changed: 12 additions & 14 deletions

File tree

grpc/tests/datetime_utils_test.cpp

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -152,27 +152,25 @@ TEST(DatetimeUtilsDateIsValid, DayDoesNotMatchMonth) { EXPECT_FALSE(ugrpc::IsVal
152152

153153
#if __cpp_lib_chrono >= 201907L
154154

155-
template <typename Value>
156-
concept YearMonthDaySerializationSupported = requires(const Value& value) {
157-
Parse(value, formats::parse::To<std::chrono::year_month_day>{});
158-
};
159-
160155
TEST(DatetimeUtils, ToProtoDateFromYearMonthDay) {
161156
EXPECT_TRUE(kGrpcCompare(kDate, ugrpc::ToProtoDate(kYearMonthDay)));
162157
}
163158

159+
// TODO reenable when formats:: supports serialization for std::year_month_day.
160+
#if 0
161+
164162
TEST(DatetimeUtils, ToProtoDateFromInvalidYearMonthDay) {
165-
if constexpr (YearMonthDaySerializationSupported<formats::json::Value>) {
166-
constexpr std::chrono::year_month_day
167-
kInvalidYearMonthDay(std::chrono::year(11000), std::chrono::month(4), std::chrono::day(10));
168-
UEXPECT_THROW_MSG(
169-
formats::json::ValueBuilder(kInvalidYearMonthDay).ExtractValue(),
170-
ugrpc::DateConversionError,
171-
"system_date is invalid"
172-
);
173-
}
163+
constexpr std::chrono::year_month_day
164+
kInvalidYearMonthDay(std::chrono::year(11000), std::chrono::month(4), std::chrono::day(10));
165+
UEXPECT_THROW_MSG(
166+
formats::json::ValueBuilder(kInvalidYearMonthDay).ExtractValue(),
167+
ugrpc::DateConversionError,
168+
"system_date is invalid"
169+
);
174170
}
175171

172+
#endif
173+
176174
TEST(DatetimeUtils, ToYearMonthDay) { EXPECT_EQ(kYearMonthDay, ugrpc::ToYearMonthDay(kDate)); }
177175

178176
TEST(DatetimeUtils, ToYearMonthDayInvalidDate) {

0 commit comments

Comments
 (0)