fix core/server/http: set http graceful shutdown headers after request processing

commit_hash:2133bb9d42294f032144af078f07d99c97f43d7c

Author: lexeyo

core/src/server/middlewares/graceful_shutdown_headers.cpp

@@ -4,25 +4,32 @@
 #include <fmt/ranges.h>
 
 #include <dynamic_config/variables/GRACEFUL_SHUTDOWN_HEADERS.hpp>
-
 #include <server/request/internal_request_context.hpp>
 #include <userver/components/component_config.hpp>
 #include <userver/components/component_context.hpp>
+#include <userver/dynamic_config/storage/component.hpp>
 #include <userver/server/http/http_request.hpp>
 #include <userver/server/request/request_context.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
 namespace server::middlewares {
 
-GracefulShutdownHeaders::GracefulShutdownHeaders(const handlers::HttpHandlerBase&, const components::State& state)
+GracefulShutdownHeaders::GracefulShutdownHeaders(
+    const handlers::HttpHandlerBase&,
+    const components::State& state,
+    const dynamic_config::Source& config_source
+)
     : HttpMiddlewareBase(),
-      state_(state)
+      state_(state),
+      config_source_(config_source)
 {}
 
 void GracefulShutdownHeaders::HandleRequest(http::HttpRequest& request, request::RequestContext& context) const {
+    Next(request, context);
+
     if (state_.GetServiceLifetimeStage() == components::ServiceLifetimeStage::kGracefulShutdown) {
-        const auto config = context.GetInternalContext().GetConfigSnapshot();
+        const auto config = config_source_.GetSnapshot();
         auto graceful_shutdown_headers = config[::dynamic_config::GRACEFUL_SHUTDOWN_HEADERS];
         if (graceful_shutdown_headers.enabled) {
             auto& response = request.GetHttpResponse();
@@ -31,23 +38,22 @@ void GracefulShutdownHeaders::HandleRequest(http::HttpRequest& request, request:
             }
         }
     }
-
-    Next(request, context);
 }
 
 GracefulShutdownHeadersFactory::GracefulShutdownHeadersFactory(
     const components::ComponentConfig& config,
     const components::ComponentContext& context
 )
     : HttpMiddlewareFactoryBase(config, context),
-      state_(context)
+      state_(context),
+      config_source_(context.FindComponent<components::DynamicConfig>().GetSource())
 {}
 
 std::unique_ptr<HttpMiddlewareBase> GracefulShutdownHeadersFactory::Create(
     const handlers::HttpHandlerBase& handler,
     yaml_config::YamlConfig
 ) const {
-    return std::make_unique<GracefulShutdownHeaders>(handler, state_);
+    return std::make_unique<GracefulShutdownHeaders>(handler, state_, config_source_);
 }
 
 }  // namespace server::middlewares

core/src/server/middlewares/graceful_shutdown_headers.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <userver/components/state.hpp>
+#include <userver/dynamic_config/source.hpp>
 #include <userver/server/middlewares/builtin.hpp>
 #include <userver/server/middlewares/http_middleware_base.hpp>
 USERVER_NAMESPACE_BEGIN
@@ -9,12 +10,17 @@ namespace server::middlewares {
 
 class GracefulShutdownHeaders final : public HttpMiddlewareBase {
 public:
-    explicit GracefulShutdownHeaders(const handlers::HttpHandlerBase&, const components::State& state);
+    explicit GracefulShutdownHeaders(
+        const handlers::HttpHandlerBase&,
+        const components::State& state,
+        const dynamic_config::Source& config_source
+    );
 
 private:
     void HandleRequest(http::HttpRequest& request, request::RequestContext& context) const override;
 
     const components::State state_;
+    const dynamic_config::Source config_source_;
 };
 
 class GracefulShutdownHeadersFactory final : public HttpMiddlewareFactoryBase {
@@ -30,6 +36,7 @@ class GracefulShutdownHeadersFactory final : public HttpMiddlewareFactoryBase {
     ) const override;
 
     const components::State state_;
+    const dynamic_config::Source config_source_;
 };
 
 }  // namespace server::middlewares