Skip to content

Commit d2a20ca

Browse files
committed
Intermediate changes
commit_hash:140d504a94c4880223aedd639cad7c222a722936
1 parent e525a99 commit d2a20ca

4 files changed

Lines changed: 1 addition & 44 deletions

File tree

core/functional_tests/basic_chaos/tests-deadline/test_client.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,12 @@
11
import asyncio
2-
import datetime
32

43
import pytest
54

65
DP_TIMEOUT_MS = 'X-YaTaxi-Client-TimeoutMs'
76
DP_DEADLINE_EXPIRED = 'X-YaTaxi-Deadline-Expired'
8-
DP_ABSOLUTE_DEADLINE = 'X-Request-Deadline'
97
VERSION = {'version': '2'}
108

119

12-
def _make_iso_deadline(offset_seconds: float) -> str:
13-
tp = datetime.datetime.now(datetime.timezone.utc) + datetime.timedelta(
14-
seconds=offset_seconds,
15-
)
16-
return tp.strftime('%Y-%m-%dT%H:%M:%S.') + f'{tp.microsecond:06d}Z'
17-
18-
1910
@pytest.fixture(name='call')
2011
def _call(service_client, mockserver_info):
2112
async def _call(htype='common', headers=None, **args):
@@ -394,22 +385,3 @@ async def test_dp_timeout_not_retried(
394385
assert response.text == ''
395386

396387
assert fake_deadline_expired_mock.times_called == retries_performed
397-
398-
399-
async def test_absolute_deadline_propagated_as_is(call, mockserver):
400-
iso_deadline = _make_iso_deadline(10.0)
401-
captured = {}
402-
403-
@mockserver.handler('/test')
404-
async def mock(request):
405-
captured['headers'] = dict(request.headers)
406-
return mockserver.make_response('OK!')
407-
408-
response = await call(
409-
headers={
410-
DP_TIMEOUT_MS: '500',
411-
DP_ABSOLUTE_DEADLINE: iso_deadline,
412-
},
413-
)
414-
assert response.status == 200
415-
assert captured['headers'].get(DP_ABSOLUTE_DEADLINE) == iso_deadline

core/functional_tests/basic_chaos/tests-deadline/test_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ async def test_absolute_deadline_disabled_dynamically(call):
139139
headers={
140140
**HEADERS,
141141
DP_TIMEOUT_MS: '5000',
142-
DP_ABSOLUTE_DEADLINE: _make_iso_deadline(-1.0),
142+
DP_ABSOLUTE_DEADLINE: _make_iso_deadline(-120.0),
143143
},
144144
)
145145
assert response.status == 200

core/src/clients/http/request_state.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include <userver/utils/algo.hpp>
2525
#include <userver/utils/assert.hpp>
2626
#include <userver/utils/async.hpp>
27-
#include <userver/utils/datetime_light.hpp>
2827
#include <userver/utils/encoding/hex.hpp>
2928
#include <userver/utils/from_string.hpp>
3029
#include <userver/utils/overloaded.hpp>
@@ -971,16 +970,6 @@ void RequestState::UpdateTimeoutHeader() {
971970
fmt::to_string(remote_timeout_.count()),
972971
curl::easy::DuplicateHeaderAction::kReplace
973972
);
974-
975-
if (inherited_original_deadline_.has_value()) {
976-
const auto
977-
iso_str = utils::datetime::UtcTimestring(*inherited_original_deadline_, utils::datetime::kTaximeterFormat);
978-
easy().add_header(
979-
USERVER_NAMESPACE::http::headers::kXRequestDeadline,
980-
iso_str,
981-
curl::easy::DuplicateHeaderAction::kReplace
982-
);
983-
}
984973
}
985974

986975
void RequestState::HandleDeadlineAlreadyPassed() {
@@ -1107,7 +1096,6 @@ void RequestState::ResetDataForNewRequest() {
11071096
retry_.current = 1;
11081097
remote_timeout_ = original_timeout_;
11091098
deadline_ = server::request::GetTaskInheritedDeadline();
1110-
inherited_original_deadline_ = server::request::GetTaskInheritedOriginalDeadline();
11111099
deadline_expired_ = false;
11121100
timeout_updated_by_deadline_ = false;
11131101

core/src/clients/http/request_state.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include <userver/engine/single_consumer_event.hpp>
2323
#include <userver/http/common_headers.hpp>
2424
#include <userver/http/url.hpp>
25-
#include <userver/server/request/task_inherited_data.hpp>
2625
#include <userver/tracing/in_place_span.hpp>
2726
#include <userver/tracing/manager.hpp>
2827
#include <userver/tracing/span.hpp>
@@ -237,8 +236,6 @@ class RequestState : public std::enable_shared_from_this<RequestState> {
237236
std::chrono::milliseconds remote_timeout_;
238237

239238
DeadlinePropagationConfig deadline_propagation_config_;
240-
/// original absolute deadline from task inherited data
241-
std::optional<server::request::TaskInheritedOriginalDeadline> inherited_original_deadline_;
242239
/// deadline from current task
243240
engine::Deadline deadline_;
244241
bool timeout_updated_by_deadline_{false};

0 commit comments

Comments
 (0)