go fix

vbauerster · vbauerster · commit 3e0412010708 · 2026-03-03T07:36:59.000+05:00
diff --git a/README.md b/README.md
@@ -50,7 +50,7 @@ func main() {
     )
     // simulating some work
     max := 100 * time.Millisecond
-    for i := 0; i < total; i++ {
+    for range total {
         time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)
         bar.Increment()
     }
@@ -68,7 +68,7 @@ func main() {
     total, numBars := 100, 3
     wg.Add(numBars)
 
-    for i := 0; i < numBars; i++ {
+    for i := range numBars {
         name := fmt.Sprintf("Bar#%d:", i)
         bar := p.AddBar(int64(total),
             mpb.PrependDecorators(
@@ -90,7 +90,7 @@ func main() {
             defer wg.Done()
             rng := rand.New(rand.NewSource(time.Now().UnixNano()))
             max := 100 * time.Millisecond
-            for i := 0; i < total; i++ {
+            for range total {
                 // start variable is solely for EWMA calculation
                 // EWMA's unit of measure is an iteration's duration
                 start := time.Now()
diff --git a/_examples/barExtender/main.go b/_examples/barExtender/main.go
@@ -18,7 +18,7 @@ func main() {
 	total, numBars := 100, 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		efn := func(w io.Writer, s decor.Statistics) (err error) {
 			if s.Completed {
@@ -47,7 +47,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/barExtenderRev/main.go b/_examples/barExtenderRev/main.go
@@ -27,7 +27,7 @@ func main() {
 	var filler mpb.BarFiller
 	tasks := make([]*task, numTasks)
 
-	for i := 0; i < numTasks; i++ {
+	for i := range numTasks {
 		task := &task{
 			id:    uint32(i),
 			total: rand.Int63n(666) + 100,
@@ -41,7 +41,7 @@ func main() {
 
 	p := mpb.New()
 
-	for i := 0; i < numTasks; i++ {
+	for i := range numTasks {
 		bar := p.AddBar(tasks[i].total,
 			mpb.BarExtender(filler, true), // all bars share same extender filler
 			mpb.BarFuncOptional(func() mpb.BarOption {
diff --git a/_examples/cancel/main.go b/_examples/cancel/main.go
@@ -22,7 +22,7 @@ func main() {
 	numBars := 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%02d: ", i)
 		bar := p.AddBar(int64(total),
 			mpb.PrependDecorators(
diff --git a/_examples/decoratorsOnTop/main.go b/_examples/decoratorsOnTop/main.go
@@ -29,7 +29,7 @@ func main() {
 	)
 	// simulating some work
 	max := 100 * time.Millisecond
-	for i := 0; i < total; i++ {
+	for range total {
 		time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)
 		bar.Increment()
 	}
diff --git a/_examples/differentWidth/main.go b/_examples/differentWidth/main.go
@@ -20,7 +20,7 @@ func main() {
 	total, numBars := 100, 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			// set BarWidth 40 for bar 1 and 2
@@ -44,7 +44,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/io/main.go b/_examples/io/main.go
@@ -15,7 +15,7 @@ func main() {
 	r, w := io.Pipe()
 
 	go func() {
-		for i := 0; i < 1024; i++ {
+		for range 1024 {
 			_, _ = io.Copy(w, io.LimitReader(rand.Reader, 64*1024))
 			time.Sleep(time.Second / 10)
 		}
diff --git a/_examples/mexicanBar/main.go b/_examples/mexicanBar/main.go
@@ -37,7 +37,7 @@ func main() {
 	)
 	// simulating some work
 	max := 100 * time.Millisecond
-	for i := 0; i < total; i++ {
+	for range total {
 		time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)
 		bar.Increment()
 	}
diff --git a/_examples/multiBars/main.go b/_examples/multiBars/main.go
@@ -17,7 +17,7 @@ func main() {
 	total, numBars := 100, 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			mpb.PrependDecorators(
@@ -39,7 +39,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/poplog/main.go b/_examples/poplog/main.go
@@ -13,7 +13,7 @@ func main() {
 	rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 	p := mpb.New(mpb.PopCompletedMode())
 	total, numBars := 100, 4
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			mpb.BarFillerOnComplete(fmt.Sprintf("%s has been completed", name)),
@@ -29,7 +29,7 @@ func main() {
 		)
 		// simulating some work
 		max := 100 * time.Millisecond
-		for i := 0; i < total; i++ {
+		for range total {
 			// start variable is solely for EWMA calculation
 			// EWMA's unit of measure is an iteration's duration
 			start := time.Now()
diff --git a/_examples/progressAsWriter/main.go b/_examples/progressAsWriter/main.go
@@ -15,7 +15,7 @@ func main() {
 	total, numBars := 100, 2
 	var bwg sync.WaitGroup
 	bwg.Add(numBars)
-	done, exit := make(chan interface{}), make(chan interface{})
+	done, exit := make(chan any), make(chan any)
 	p := mpb.New(
 		mpb.WithWidth(64),
 		mpb.WithShutdownNotifier(done),
@@ -44,7 +44,7 @@ func main() {
 
 	nopBar := p.MustAdd(0, nil)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			mpb.PrependDecorators(
@@ -62,7 +62,7 @@ func main() {
 			defer bwg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/queueBar/main.go b/_examples/queueBar/main.go
@@ -20,7 +20,7 @@ func main() {
 
 	red, green := color.New(color.FgRed), color.New(color.FgGreen)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		task := fmt.Sprintf("Task#%02d:", i)
 		b1 := p.AddBar(rand.Int63n(101)+100,
 			mpb.PrependDecorators(
diff --git a/_examples/quietMode/main.go b/_examples/quietMode/main.go
@@ -29,7 +29,7 @@ func main() {
 	total, numBars := 100, 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			mpb.PrependDecorators(
@@ -51,7 +51,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/remove/main.go b/_examples/remove/main.go
@@ -18,7 +18,7 @@ func main() {
 	numBars := 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			mpb.BarID(i),
diff --git a/_examples/reverseBar/main.go b/_examples/reverseBar/main.go
@@ -24,7 +24,7 @@ func main() {
 		return mpb.BarStyle()
 	}
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.New(int64(total),
 			condFillerBuilder(i == 1),
@@ -47,7 +47,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/singleBar/main.go b/_examples/singleBar/main.go
@@ -28,7 +28,7 @@ func main() {
 	)
 	// simulating some work
 	max := 100 * time.Millisecond
-	for i := 0; i < total; i++ {
+	for range total {
 		time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)
 		bar.Increment()
 	}
diff --git a/_examples/spinTipBar/main.go b/_examples/spinTipBar/main.go
@@ -23,7 +23,7 @@ func main() {
 	)
 	// simulating some work
 	max := 100 * time.Millisecond
-	for i := 0; i < total; i++ {
+	for range total {
 		time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)
 		bar.Increment()
 	}
diff --git a/_examples/spinnerBar/main.go b/_examples/spinnerBar/main.go
@@ -30,7 +30,7 @@ func main() {
 		return mpb.BarStyle().Lbound("╢").Filler("▌").Tip("▌").Padding("░").Rbound("╟")
 	}
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.New(int64(total),
 			condFillerBuilder(i != 0),
@@ -51,7 +51,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				// start variable is solely for EWMA calculation
 				// EWMA's unit of measure is an iteration's duration
 				start := time.Now()
diff --git a/_examples/spinnerDecorator/main.go b/_examples/spinnerDecorator/main.go
@@ -17,7 +17,7 @@ func main() {
 	total, numBars := 100, 3
 	wg.Add(numBars)
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		name := fmt.Sprintf("Bar#%d:", i)
 		bar := p.AddBar(int64(total),
 			mpb.PrependDecorators(
@@ -38,7 +38,7 @@ func main() {
 			defer wg.Done()
 			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 			max := 100 * time.Millisecond
-			for i := 0; i < total; i++ {
+			for range total {
 				time.Sleep(time.Duration(rng.Intn(10)+1) * max / 10)
 				bar.Increment()
 			}
diff --git a/_examples/stress/main.go b/_examples/stress/main.go
@@ -36,7 +36,7 @@ func main() {
 	)
 	wg.Add(totalBars)
 
-	for i := 0; i < totalBars; i++ {
+	for i := range totalBars {
 		name := fmt.Sprintf("Bar#%02d: ", i)
 		total := rand.Intn(320) + 10
 		bar := p.AddBar(int64(total),
diff --git a/_examples/suppressBar/main.go b/_examples/suppressBar/main.go
@@ -22,7 +22,7 @@ func main() {
 	})
 	defer timer.Stop()
 
-	for i := 0; i < numBars; i++ {
+	for i := range numBars {
 		msgCh := make(chan string, 1)
 		bar := p.AddBar(int64(total),
 			mpb.PrependDecorators(newTitleDecorator(fmt.Sprintf("Bar#%d:", i), msgCh, 16)),
diff --git a/_examples/tipOnComplete/main.go b/_examples/tipOnComplete/main.go
@@ -21,7 +21,7 @@ func main() {
 	)
 	// simulating some work
 	max := 100 * time.Millisecond
-	for i := 0; i < total; i++ {
+	for range total {
 		time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)
 		bar.Increment()
 	}
diff --git a/bar_heap.go b/bar_heap.go
@@ -20,13 +20,13 @@ func (s barHeap) Swap(i, j int) {
 	s[j].index = j
 }
 
-func (h *barHeap) Push(x interface{}) {
+func (h *barHeap) Push(x any) {
 	b := x.(*Bar)
 	b.index = h.Len()
 	*h = append(*h, b)
 }
 
-func (h *barHeap) Pop() interface{} {
+func (h *barHeap) Pop() any {
 	s := *h
 	i := s.Len() - 1
 	b := s[i]
diff --git a/bar_test.go b/bar_test.go
@@ -268,7 +268,7 @@ func TestDecorStatisticsAvailableWidth(t *testing.T) {
 		return ""
 	}
 	ctx, cancel := context.WithCancel(context.Background())
-	refresh := make(chan interface{})
+	refresh := make(chan any)
 	p := mpb.NewWithContext(ctx,
 		mpb.WithWidth(100),
 		mpb.WithManualRefresh(refresh),
@@ -307,7 +307,7 @@ func TestDecorStatisticsAvailableWidth(t *testing.T) {
 }
 
 func TestBarQueueAfterBar(t *testing.T) {
-	shutdown := make(chan interface{})
+	shutdown := make(chan any)
 	handOverBarHeap := make(chan []*mpb.Bar, 1)
 	ctx, cancel := context.WithCancel(context.Background())
 	p := mpb.NewWithContext(ctx,
@@ -347,7 +347,7 @@ func TestBarQueueAfterBar(t *testing.T) {
 }
 
 func TestBarRemoveOnComplete(t *testing.T) {
-	shutdown := make(chan interface{})
+	shutdown := make(chan any)
 	handOverBarHeap := make(chan []*mpb.Bar, 1)
 	p := mpb.New(
 		mpb.WithOutput(io.Discard),
diff --git a/barbench_test.go b/barbench_test.go
@@ -67,7 +67,7 @@ func bench(b *testing.B, builder mpb.BarFillerBuilder, autoRefresh bool, n int)
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		var bars []*mpb.Bar
-		for j := 0; j < n; j++ {
+		for j := range n {
 			bars = append(bars, p.New(total, builder))
 			switch j {
 			case n - 1:
@@ -83,7 +83,7 @@ func bench(b *testing.B, builder mpb.BarFillerBuilder, autoRefresh bool, n int)
 }
 
 func complete(bar *mpb.Bar) {
-	for i := 0; i < total; i++ {
+	for range total {
 		bar.Increment()
 	}
 }
diff --git a/container_option.go b/container_option.go
diff --git a/decor/moving_average.go b/decor/moving_average.go
diff --git a/example_test.go b/example_test.go
diff --git a/heap_manager.go b/heap_manager.go
diff --git a/progress.go b/progress.go
diff --git a/progress_test.go b/progress_test.go

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func main() {`
`29`	`29`	`)`
`30`	`30`	`// simulating some work`
`31`	`31`	`max := 100 * time.Millisecond`
`32`		`- for i := 0; i < total; i++ {`
	`32`	`+ for range total {`
`33`	`33`	`time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)`
`34`	`34`	`bar.Increment()`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ func main() {`
`15`	`15`	`r, w := io.Pipe()`
`16`	`16`
`17`	`17`	`go func() {`
`18`		`- for i := 0; i < 1024; i++ {`
	`18`	`+ for range 1024 {`
`19`	`19`	`_, _ = io.Copy(w, io.LimitReader(rand.Reader, 64*1024))`
`20`	`20`	`time.Sleep(time.Second / 10)`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ func main() {`
`37`	`37`	`)`
`38`	`38`	`// simulating some work`
`39`	`39`	`max := 100 * time.Millisecond`
`40`		`- for i := 0; i < total; i++ {`
	`40`	`+ for range total {`
`41`	`41`	`time.Sleep(time.Duration(rand.Intn(10)+1) * max / 10)`
`42`	`42`	`bar.Increment()`
`43`	`43`	`}`