fix empty duplicate id

mayeco · mayeco · commit 4a2a1fef5226 · 2014-11-28T15:08:46.000-05:00
diff --git a/EventListener/StringGeneratorListener.php b/EventListener/StringGeneratorListener.php
@@ -73,7 +73,7 @@ private function generateId($property, Vivait\StringGenerator $annotation)
         }
 
         if ($this->repo->findOneBy([$property => $str])) {
-            $this->generateId($property, $annotation);
+            return $this->generateId($property, $annotation);
         } else {
             return $str;
         }
@@ -82,4 +82,4 @@ private function generateId($property, Vivait\StringGenerator $annotation)
     }
 
 
-} 
+} 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ private function generateId($property, Vivait\StringGenerator $annotation)`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`if ($this->repo->findOneBy([$property => $str])) {`
`76`		`- $this->generateId($property, $annotation);`
	`76`	`+ return $this->generateId($property, $annotation);`
`77`	`77`	`} else {`
`78`	`78`	`return $str;`
`79`	`79`	`}`
`@@ -82,4 +82,4 @@ private function generateId($property, Vivait\StringGenerator $annotation)`
`82`	`82`	`}`
`83`	`83`
`84`	`84`
`85`		`-}`
	`85`	`+}`