Code quality fixes

Author: Robin Cawser

src/Vivait/StringGeneratorBundle/Generator/SecureBytesGenerator.php

@@ -24,11 +24,12 @@ public function __construct(SecureRandom $secureRandom)
 
     /**
      * @param integer $length
-     * @return $this
+     * @return ConfigurableGeneratorInterface
      */
     public function setLength($length)
     {
         $this->length = $length;
+        return $this;
     }
 
     /**

src/Vivait/StringGeneratorBundle/Generator/SecureStringGenerator.php

@@ -35,7 +35,6 @@ class SecureStringGenerator implements ConfigurableGeneratorInterface
      */
     public function __construct(Factory $factory)
     {
-
         $this->factory = $factory;
     }
 
@@ -83,12 +82,13 @@ public function getDefaultOptions(OptionsResolver $resolver)
 
     /**
      * @param integer $length
-     * @return $this
+     * @return ConfigurableGeneratorInterface
      * @deprecated this will be deprecated in version 2.0 in favour of using callbacks on the generator. This is due to
      * some generators not actually needing a length - only random string type generators require it.
      */
     public function setLength($length)
     {
-        // TODO: Implement setLength() method.
+        $this->length = $length;
+        return $this;
     }
 }

src/Vivait/StringGeneratorBundle/Generator/StringGenerator.php

@@ -39,20 +39,23 @@ public function setChars($chars)
     /**
      * Set the length of the generated string
      * @param $length
-     * @return $this
+     * @return ConfigurableGeneratorInterface
      */
     public function setLength($length)
     {
         $this->length = $length;
+        return $this;
     }
 
     /**
      * @param $prefix
+     * @return ConfigurableGeneratorInterface
      * @deprecated options should be used instead
      */
     public function setPrefix($prefix)
     {
         $this->prefix = $prefix;
+        return $this;
     }
 
     /**

src/Vivait/StringGeneratorBundle/Model/ConfigurableGeneratorInterface.php

@@ -14,7 +14,7 @@ public function setOptions(array $options);
 
     /**
      * @param OptionsResolver $resolver
-     * @return mixed
+     * @return void|OptionsResolver
      */
     public function getDefaultOptions(OptionsResolver $resolver);
 }

src/Vivait/StringGeneratorBundle/Model/GeneratorInterface.php

@@ -6,7 +6,7 @@ interface GeneratorInterface
 {
     /**
      * @param integer $length
-     * @return $this
+     * @return GeneratorInterface
      * @deprecated this will be deprecated in version 2.0 in favour of using callbacks on the generator. This is due to
      * some generators not actually needing a length - only random string type generators require it.
      */