Merge pull request #16 from robcaw/master

Code quality fixes

Author: rcwsr

src/Vivait/StringGeneratorBundle/EventListener/GeneratorListener.php

@@ -20,31 +20,33 @@ class GeneratorListener
      * @var EntityRepository
      */
     private $repo;
-    /**
-     * @var GeneratorInterface
-     */
-    private $generator;
 
     /**
      * @var Registry
      */
     private $registry;
 
+    /**
+     * @var ContainerInterface
+     */
     private $container;
 
     /**
      * Registry has been made nullable as injecting it causes circular references. Instead, the container is injected
      * via a setter, and the registry is fetched from there instead.
      *
      * @param Reader $reader
-     * @param Registry $registry
+     * @param null|Registry $registry
      */
     public function __construct(Reader $reader, Registry $registry = null)
     {
         $this->reader = $reader;
         $this->registry = $registry;
     }
 
+    /**
+     * @param ContainerInterface $container
+     */
     public function setContainer(ContainerInterface $container)
     {
         $this->container = $container;
@@ -88,6 +90,7 @@ private function generateString($property, GeneratorAnnotation $annotation, $obj
     {
         /** @var GeneratorInterface $generator */
         $generator = $this->getRegistry()->get($annotation->generator);
+
         $generator->setLength($annotation->length);
 
         if(!empty($annotation->callbacks)){

src/Vivait/StringGeneratorBundle/Generator/SecureBytesGenerator.php

@@ -28,6 +28,7 @@ public function __construct(SecureRandom $secureRandom)
     public function setLength($length)
     {
         $this->length = $length;
+        return $this;
     }
 
     /**

src/Vivait/StringGeneratorBundle/Registry/Registry.php

@@ -12,6 +12,11 @@ class Registry
      */
     private $generators;
 
+    /**
+     * @var ContainerInterface
+     */
+    private $container;
+
     /**
      * @param ContainerInterface $container
      * @param array $generators
@@ -22,6 +27,11 @@ function __construct(ContainerInterface $container, array $generators = [])
         $this->addAll($generators);
     }
 
+    /**
+     * @param $field
+     * @return GeneratorInterface
+     * @throws \OutOfBoundsException
+     */
     public function get($field)
     {
         if (isset($this->generators[$field])) {
@@ -31,6 +41,11 @@ public function get($field)
         throw new \OutOfBoundsException(sprintf('Field "%s" not found in registry', $field));
     }
 
+    /**
+     * @param $field
+     * @param $class
+     * @return $this
+     */
     public function add($field, $class)
     {
         $this->generators[$field] = $this->resolveGeneratorType($class);