Skip to content

Commit 2ad173d

Browse files
authored
fix: nested block on, make materialize async (#7618)
Calling `block_on` in `load_patches_to_gpu` caused a crash when running the benchmark, as the bench runner also calls block on which led to nested executors. Copies and async usage will be reworked holistically as part of the bigger work stream making data loading fast. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
1 parent 91a6b57 commit 2ad173d

6 files changed

Lines changed: 69 additions & 68 deletions

File tree

vortex-cuda/benches/dynamic_dispatch_cuda.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ use cudarc::driver::DevicePtr;
1717
use cudarc::driver::LaunchConfig;
1818
use cudarc::driver::PushKernelArg;
1919
use cudarc::driver::sys::CUevent_flags;
20+
use futures::executor::block_on;
2021
use vortex::array::IntoArray;
2122
use vortex::array::LEGACY_SESSION;
2223
use vortex::array::VortexSessionExecute;
@@ -133,7 +134,7 @@ impl BenchRunner {
133134
device_buffers,
134135
shared_mem_bytes,
135136
..
136-
} = plan.materialize(cuda_ctx).vortex_expect("materialize plan");
137+
} = block_on(plan.materialize(cuda_ctx)).vortex_expect("materialize plan");
137138

138139
let device_plan = Arc::new(
139140
cuda_ctx

0 commit comments

Comments
 (0)