Skip to content

Commit 5b6523a

Browse files
committed
Eliminate SonarQube warnings
1 parent 87675d1 commit 5b6523a

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

  • conga-aem-plugin/src/main/java/io/wcm/devops/conga/plugins/aem/handlebars/helper
  • tooling/conga-aem-crypto-cli/src/main/java/io/wcm/devops/conga/plugins/aem/tooling/crypto/cli

conga-aem-plugin/src/main/java/io/wcm/devops/conga/plugins/aem/handlebars/helper/AemHttpdFilterHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ protected String generateFilter(Map<String, Object> filterMap, Options options)
7373
allowFrom, allowFromHost);
7474
}
7575

76-
@SuppressWarnings("java:S3776") // ignore complexity
76+
@SuppressWarnings({ "java:S3776", "java:S1192" }) // ignore complexity
7777
private String generateRule(String ruleType, String ruleExpression, HttpdFilterType filterType,
7878
String allowFrom, String allowFromHost) {
7979
StringBuilder sb = new StringBuilder();

tooling/conga-aem-crypto-cli/src/main/java/io/wcm/devops/conga/plugins/aem/tooling/crypto/cli/CryptoKeys.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ private static Stream<KeyItem> encryptKeys(Stream<KeyItem> keys, String password
9191
@SuppressWarnings("java:S112") // runtime exception
9292
private static Stream<File> writeKeys(Stream<KeyItem> keys, File targetDir) {
9393
if (!targetDir.exists()) {
94-
if (!targetDir.mkdirs()) {
94+
boolean created = targetDir.mkdirs();
95+
if (!created) {
9596
throw new RuntimeException("Unable to create directories: " + targetDir.getPath());
9697
}
9798
}

0 commit comments

Comments
 (0)