Skip to content

Commit 8a5fb0d

Browse files
committed
do not generate additional dependencies for sub packages
1 parent 43797f7 commit 8a5fb0d

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

tooling/conga-aem-maven-plugin/src/main/java/io/wcm/devops/conga/plugins/aem/maven/allpackage/AllPackageBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ else if (StringUtils.equals(FilenameUtils.getExtension(zipInEntry.getName()), "z
378378
try (FileOutputStream subPackageFos = new FileOutputStream(tempSubPackageFile)) {
379379
IOUtils.copy(is, subPackageFos);
380380
}
381-
File resultSubPackageFile = processContentPackage(tempSubPackageFile, pkg, previousPkg, environmentRunMode, allPackagesFromFileSets);
381+
File resultSubPackageFile = processContentPackage(tempSubPackageFile, pkg, null, environmentRunMode, allPackagesFromFileSets);
382382
try (FileInputStream subPackageFis = new FileInputStream(resultSubPackageFile)) {
383383
ZipEntry zipOutEntry = new ZipEntry(path + basename + runModeSuffix + ".zip");
384384
zipOut.putNextEntry(zipOutEntry);

tooling/conga-aem-maven-plugin/src/test/java/io/wcm/devops/conga/plugins/aem/maven/allpackage/AllPackageBuilderTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,7 @@ void testBuild_IMMUTABLE_MUTABLE_COMBINED(Set<String> cloudManagerTarget, List<S
216216
"adobe/consulting:acs-aem-commons-ui.content" + runmodeSuffix + ":4.10.0");
217217
assertNameDependenciesSubPackage(containerInstallDir, "accesscontroltool-package" + runmodeSuffix + "-3.0.0.zip",
218218
"jcr_root/apps/netcentric/actool/install/accesscontroltool-apps-package-3.0.0" + runmodeSuffix + ".zip",
219-
"accesscontroltool-apps-package" + runmodeSuffix,
220-
"adobe/consulting:acs-aem-commons-ui.content" + runmodeSuffix + ":4.10.0");
219+
"accesscontroltool-apps-package" + runmodeSuffix);
221220
assertNameDependencies(containerInstallDir, "wcm-io-samples-aem-cms-config" + runmodeSuffix + ".zip",
222221
"wcm-io-samples-aem-cms-config" + runmodeSuffix,
223222
"wcm-io-samples:aem-cms-system-config" + runmodeSuffix + ":1.3.1-SNAPSHOT");
@@ -295,8 +294,7 @@ void testBuild_IMMUTABLE_MUTABLE_SEPARATE(Set<String> cloudManagerTarget, List<S
295294
"adobe/consulting:acs-aem-commons-ui.apps" + runmodeSuffix + ":4.10.0");
296295
assertNameDependenciesSubPackage(containerInstallDir, "accesscontroltool-package" + runmodeSuffix + "-3.0.0.zip",
297296
"jcr_root/apps/netcentric/actool/install/accesscontroltool-apps-package-3.0.0" + runmodeSuffix + ".zip",
298-
"accesscontroltool-apps-package" + runmodeSuffix,
299-
"adobe/consulting:acs-aem-commons-ui.apps" + runmodeSuffix + ":4.10.0");
297+
"accesscontroltool-apps-package" + runmodeSuffix);
300298
assertNameDependencies(containerInstallDir, "wcm-io-samples-aem-cms-config" + runmodeSuffix + ".zip",
301299
"wcm-io-samples-aem-cms-config" + runmodeSuffix,
302300
"wcm-io-samples:aem-cms-system-config" + runmodeSuffix + ":1.3.1-SNAPSHOT");
@@ -372,8 +370,7 @@ void testBuild_IMMUTABLE_ONLY(Set<String> cloudManagerTarget, List<String> runmo
372370
"adobe/consulting:acs-aem-commons-ui.apps" + runmodeSuffix + ":4.10.0");
373371
assertNameDependenciesSubPackage(containerInstallDir, "accesscontroltool-package" + runmodeSuffix + "-3.0.0.zip",
374372
"jcr_root/apps/netcentric/actool/install/accesscontroltool-apps-package-3.0.0" + runmodeSuffix + ".zip",
375-
"accesscontroltool-apps-package" + runmodeSuffix,
376-
"adobe/consulting:acs-aem-commons-ui.apps" + runmodeSuffix + ":4.10.0");
373+
"accesscontroltool-apps-package" + runmodeSuffix);
377374
assertNameDependencies(containerInstallDir, "wcm-io-samples-aem-cms-config" + runmodeSuffix + ".zip",
378375
"wcm-io-samples-aem-cms-config" + runmodeSuffix,
379376
"wcm-io-samples:aem-cms-system-config" + runmodeSuffix + ":1.3.1-SNAPSHOT");

0 commit comments

Comments
 (0)