Skip to content

Commit 1af57e2

Browse files
committed
Use pdf.worker.js to work around a bug in pdf.js which doesn't allow
disabling workers. Make the build directory Viewer.js instead of viewer.
1 parent 16931c2 commit 1af57e2

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

CMakeLists.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ else ( IS_DIRECTORY $ENV{VIEWERJS_DOWNLOAD_DIR} )
5555
endif ( IS_DIRECTORY $ENV{VIEWERJS_DOWNLOAD_DIR} )
5656
MESSAGE ( STATUS "external downloads will be stored/expected in: ${EXTERNALS_DOWNLOAD_DIR}" )
5757

58-
SET ( VIEWER_BUILD_DIR ${CMAKE_BINARY_DIR}/viewer )
58+
SET ( VIEWER_BUILD_DIR ${CMAKE_BINARY_DIR}/Viewer.js )
5959
FILE ( MAKE_DIRECTORY ${VIEWER_BUILD_DIR})
6060
SET ( VIEWERZIP ${CMAKE_BINARY_DIR}/Viewer.js-${VIEWERJS_VERSION}.zip)
6161
SET ( WEBODF_SOURCE_DIR ${CMAKE_BINARY_DIR}/WebODF-source )
@@ -66,7 +66,7 @@ ExternalProject_Add(
6666
SOURCE_DIR ${WEBODF_SOURCE_DIR}
6767
UPDATE_COMMAND git pull origin master
6868
BUILD_COMMAND make viewerbuilddir-target
69-
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy_directory <BINARY_DIR>/viewer/ ${VIEWER_BUILD_DIR}
69+
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy_directory <BINARY_DIR>/viewer/ ${CMAKE_BINARY_DIR}/viewer
7070
)
7171

7272
ExternalProject_Add(
@@ -75,11 +75,12 @@ ExternalProject_Add(
7575
UPDATE_COMMAND git pull
7676
CONFIGURE_COMMAND ""
7777
BUILD_COMMAND node <SOURCE_DIR>/make.js generic
78-
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/build/generic/build/pdf.js ${VIEWER_BUILD_DIR}/pdf.js
78+
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/build/generic/build/pdf.js ${CMAKE_BINARY_DIR}/viewer/pdf.js COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/build/generic/build/pdf.worker.js ${CMAKE_BINARY_DIR}/viewer/pdf.worker.js
7979
)
8080

8181
add_custom_command(
8282
OUTPUT ${VIEWERZIP}
83+
COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_BINARY_DIR}/viewer ${VIEWER_BUILD_DIR}
8384
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_CURRENT_SOURCE_DIR}/PluginLoader.js ${VIEWER_BUILD_DIR}/PluginLoader.js
8485
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_CURRENT_SOURCE_DIR}/PDFViewerPlugin.js ${VIEWER_BUILD_DIR}/PDFViewerPlugin.js
8586
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_CURRENT_SOURCE_DIR}/TextLayerBuilder.js ${VIEWER_BUILD_DIR}/TextLayerBuilder.js

PDFViewerPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ function PDFViewerPlugin() {
207207
pluginCSS;
208208

209209
init(function () {
210-
PDFJS.disableWorker = true;
210+
PDFJS.workerSrc = "./pdf.worker.js";
211211
PDFJS.getDocument(location).then(function loadPDF(doc) {
212212
pdfDocument = doc;
213213
container = viewContainer;

0 commit comments

Comments
 (0)