Skip to content

Commit aa7966b

Browse files
author
Tobias Hintze
committed
fix build; do not assume automatically determined ExternalProject dirs;
also use https instead of ssh URLs to make it work for people without github account.
1 parent db9c9a7 commit aa7966b

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

CMakeLists.txt

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
#
3333

3434
project (Viewer.js)
35-
# version 2.8.2 is needed to have support for zip files in external projects
36-
# issues with version 2.8.4 on Windows makes us test for a higher version
3735
cmake_minimum_required(VERSION 2.8.6)
3836

3937
# At this point, the version number that is used throughout is defined
@@ -60,25 +58,24 @@ MESSAGE ( STATUS "external downloads will be stored/expected in: ${EXTERNALS_DOW
6058
SET ( VIEWER_BUILD_DIR ${CMAKE_BINARY_DIR}/viewer )
6159
FILE ( MAKE_DIRECTORY ${VIEWER_BUILD_DIR})
6260
SET ( VIEWERZIP ${CMAKE_BINARY_DIR}/Viewer.js-${VIEWERJS_VERSION}.zip)
63-
SET ( WEBODF_SOURCE_DIR ${CMAKE_BINARY_DIR}/WebODF-Prefix/src/WebODF )
64-
SET ( WEBODF_BUILD_DIR ${CMAKE_BINARY_DIR}/WebODF-Prefix/src/WebODF-build )
65-
SET ( PDFJS_SOURCE_DIR ${CMAKE_BINARY_DIR}/PDFjs-Prefix/src/PDFjs )
61+
SET ( WEBODF_SOURCE_DIR ${CMAKE_BINARY_DIR}/WebODF-source )
6662

6763
ExternalProject_Add(
6864
WebODF
69-
GIT_REPOSITORY git@gitorious.org:webodf/webodf.git
65+
GIT_REPOSITORY https://git.gitorious.org/webodf/webodf.git
66+
SOURCE_DIR ${WEBODF_SOURCE_DIR}
7067
UPDATE_COMMAND git pull origin master
7168
BUILD_COMMAND make viewerbuilddir-target
72-
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy_directory ${WEBODF_BUILD_DIR}/viewer/ ${VIEWER_BUILD_DIR}
69+
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy_directory <BINARY_DIR>/viewer/ ${VIEWER_BUILD_DIR}
7370
)
7471

7572
ExternalProject_Add(
7673
PDFjs
77-
GIT_REPOSITORY git@github.com:mozilla/pdf.js.git
74+
GIT_REPOSITORY https://github.com/mozilla/pdf.js.git
7875
UPDATE_COMMAND git pull
7976
CONFIGURE_COMMAND ""
80-
BUILD_COMMAND node ${PDFJS_SOURCE_DIR}/make.js generic
81-
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy ${PDFJS_SOURCE_DIR}/build/generic/build/pdf.js ${VIEWER_BUILD_DIR}/pdf.js
77+
BUILD_COMMAND node <SOURCE_DIR>/make.js generic
78+
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/build/generic/build/pdf.js ${VIEWER_BUILD_DIR}/pdf.js
8279
)
8380

8481
add_custom_command(

0 commit comments

Comments
 (0)