Let SessionController emit signalCursorMoved only via explicit helper method

Author: Friedrich W. H. Kossebau

webodf/lib/gui/SessionController.js

@@ -374,7 +374,7 @@ gui.SessionControllerOptions = function () {
                             newSelectionRange.setEnd(shadowCursorIterator.container(), shadowCursorIterator.unfilteredDomOffset());
                         }
                         shadowCursor.setSelectedRange(newSelectionRange, handleEnd === 'right');
-                        odtDocument.emit(ops.Document.signalCursorMoved, shadowCursor);
+                        odtDocument.emitSignalCursorMoved(shadowCursor);
                     }
                 }
             }
@@ -400,7 +400,7 @@ gui.SessionControllerOptions = function () {
                         selectionController.expandToParagraphBoundaries(selectionRange.range);
                     }
                     shadowCursor.setSelectedRange(selectionRange.range, selectionRange.hasForwardSelection);
-                    odtDocument.emit(ops.Document.signalCursorMoved, shadowCursor);
+                    odtDocument.emitSignalCursorMoved(shadowCursor);
                 }
             }
         }

webodf/lib/ops/OdtDocument.js

@@ -958,6 +958,15 @@ ops.OdtDocument = function OdtDocument(odfCanvas) {
         self.emit(ops.OdtDocument.signalStepsRemoved, args);
     };
 
+    /**
+     * Emit the signal that the passed cursor moved.
+     * @param {!ops.OdtCursor} cursor
+     * @return {undefined}
+     */
+    this.emitSignalCursorMoved = function(cursor) {
+        eventNotifier.emit(ops.Document.signalCursorMoved, cursor);
+    };
+
     /**
      * @return {undefined}
      */

webodf/tests/gui/DirectFormattingControllerTests.js

@@ -140,7 +140,7 @@ gui.DirectFormattingControllerTests = function DirectFormattingControllerTests(r
             domUtils.getElementsByTagNameNS(node, testns, '*').forEach(function(node) {
                 node.parentNode.removeChild(node);
             });
-            t.odtDocument.emit(ops.Document.signalCursorMoved, t.cursor);
+            t.odtDocument.emitSignalCursorMoved(t.cursor);
         }
         return node;
     }

webodf/tests/manifest.json

@@ -49,7 +49,6 @@
         "odf.ObjectNameGenerator",
         "odf.OdfCanvas",
         "odf.OdfContainer",
-        "ops.Document",
         "ops.OdtCursor",
         "ops.OdtDocument",
         "ops.Session"