Merge pull request #386 from ZKHelloworld/fix-no-name-asset

Fix assets without name causing analyze failure

Author: th0r

CHANGELOG.md

@@ -13,6 +13,8 @@ _Note: Gaps between patch versions are faulty, broken or test releases._
 ## UNRELEASED
 
 <!-- Add changelog entries for new changes under this section -->
+ * **Bug Fix**
+   * Fix `non-asset` assets causing analyze failure. ([##385](https://github.com/webpack-contrib/webpack-bundle-analyzer/issues/385) by [@ZKHelloworld](https://github.com/ZKHelloworld))
 
 ## 4.1.0
 

src/analyzer.js

@@ -49,6 +49,11 @@ function getViewerData(bundleStats, bundleDir, opts) {
 
   // Picking only `*.js or *.mjs` assets from bundle that has non-empty `chunks` array
   bundleStats.assets = _.filter(bundleStats.assets, asset => {
+    // Filter out non 'asset' type asset if type is provided (Webpack 5 add a type to indicate asset types)
+    if (asset.type && asset.type !== 'asset') {
+      return false;
+    }
+
     // Removing query part from filename (yes, somebody uses it for some reason and Webpack supports it)
     // See #22
     asset.name = asset.name.replace(FILENAME_QUERY_REGEXP, '');

test/analyzer.js

@@ -155,6 +155,11 @@ describe('Analyzer', function () {
     expect(chartData).to.containSubset(require('./stats/with-modules-in-chunks/expected-chart-data'));
   });
 
+  it('should support stats files with non-asset asset', async function () {
+    generateReportFrom('with-non-asset-asset/stats.json');
+    await expectValidReport({bundleLabel: 'bundle.js'});
+  });
+
   describe('options', function () {
     describe('title', function () {
       it('should take the --title option', async function () {