Skip to content

Commit 72c9027

Browse files
authored
chore: update ws dependency to version 8.19.0 (#691)
1 parent 09a540a commit 72c9027

4 files changed

Lines changed: 21 additions & 55 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ _Note: Gaps between patch versions are faulty, broken or test releases._
1212

1313
## UNRELEASED
1414

15+
* **Internal**
16+
* Update `ws` dependency ([#691](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/691) by [@bjohansebas](https://github.com/bjohansebas))
17+
1518
## 5.1.1
1619

1720
* **Bug Fix**

package-lock.json

Lines changed: 7 additions & 50 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"opener": "^1.5.2",
4444
"picocolors": "^1.0.0",
4545
"sirv": "^2.0.3",
46-
"ws": "^7.3.1"
46+
"ws": "^8.19.0"
4747
},
4848
"devDependencies": {
4949
"@babel/core": "7.26.9",

test/viewer.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,13 @@ describe('WebSocket server', function () {
4747
].join('\r\n'));
4848
});
4949

50+
socket.on('close', function () {
51+
server.close(done);
52+
});
53+
54+
let count = 0;
5055
socket.on('data', function (chunk) {
56+
++count;
5157
const expected = Buffer.from([
5258
'HTTP/1.1 101 Switching Protocols',
5359
'Upgrade: websocket',
@@ -57,14 +63,14 @@ describe('WebSocket server', function () {
5763
''
5864
].join('\r\n'));
5965

60-
expect(chunk.equals(expected)).to.be.true;
66+
// Because data may be received in multiple chunks, only check the first one
67+
if (count === 1) {
68+
expect(chunk.equals(expected)).to.be.true;
69+
}
6170

6271
// Send a WebSocket frame with a reserved opcode (5) to trigger an error
6372
// to be emitted on the server.
6473
socket.write(Buffer.from([0x85, 0x00]));
65-
socket.on('close', function () {
66-
server.close(done);
67-
});
6874
});
6975
})
7076
.catch(done);

0 commit comments

Comments
 (0)