Skip to content

Commit 0c3b296

Browse files
fix: do not hook assetEmitted when writeToDisk is true
1 parent 112de09 commit 0c3b296

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ function wdm(compiler, options = {}) {
229229

230230
setupHooks(context);
231231

232-
if (options.writeToDisk) {
232+
if (typeof options.writeToDisk === "function") {
233233
setupWriteToDisk(context);
234234
}
235235

test/middleware.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4056,7 +4056,7 @@ describe.each([
40564056
compiler.hooks.assetEmitted.taps.filter(
40574057
(hook) => hook.name === "DevMiddleware",
40584058
),
4059-
).toHaveLength(1);
4059+
).toHaveLength(0);
40604060
expect(fs.existsSync(bundlePath)).toBe(true);
40614061

40624062
instance.invalidate();
@@ -4068,7 +4068,7 @@ describe.each([
40684068
compiler.hooks.assetEmitted.taps.filter(
40694069
(hook) => hook.name === "DevMiddleware",
40704070
),
4071-
).toHaveLength(1);
4071+
).toHaveLength(0);
40724072

40734073
done();
40744074
},
@@ -4154,7 +4154,7 @@ describe.each([
41544154
compiler.hooks.assetEmitted.taps.filter(
41554155
(hook) => hook.name === "DevMiddleware",
41564156
),
4157-
).toHaveLength(1);
4157+
).toHaveLength(0);
41584158
expect(fs.existsSync(bundlePath)).toBe(true);
41594159

41604160
instance.invalidate();
@@ -4166,7 +4166,7 @@ describe.each([
41664166
compiler.hooks.assetEmitted.taps.filter(
41674167
(hook) => hook.name === "DevMiddleware",
41684168
),
4169-
).toHaveLength(1);
4169+
).toHaveLength(0);
41704170

41714171
done();
41724172
},

0 commit comments

Comments
 (0)