test: more

Author: alexander-akait

.changeset/late-snails-argue.md

@@ -2,4 +2,4 @@
 "webpack-dev-middleware": major
 ---
 
-The `getFilenameFromUrl` function now returns an object with the found `filename` (or `undefined` if the file was not found) and throws an error if the URL cannot be processed. Additionally, the object contains the `extra` property with `stats` (file system stats) and `outputFileSystem` (output file system where file was found) properties.
+The `getFilenameFromUrl` function is now asynchronous, returning a Promise that resolves to the object with the found `filename` (or `undefined` if the file was not found) or throws an error if the URL cannot be processed. Additionally, the object contains the `extra` property with `stats` (file system stats) and `outputFileSystem` (output file system where file was found) properties.

README.md

@@ -460,20 +460,16 @@ const app = new express();
 app.use(instance);
 
 instance.waitUntilValid(() => {
-  let resolver;
-
-  try {
-    resolved = instance.getFilenameFromUrl("/bundle.js");
-  } catch (err) {
-    console.log(`Error: ${err}`);
-  }
-
-  if (!resolved) {
-    console.log("Not found");
-    return;
-  }
-
-  console.log(`Filename is ${filename}`);
+  instance
+    .getFilenameFromUrl("/bundle.js")
+    .then(() => {
+      if (filename) {
+        console.log(`Filename is ${filename}`);
+      }
+    })
+    .catch((err) => {
+      console.log(`Error: ${err}`);
+    });
 });
 ```
 

src/index.js

@@ -14,7 +14,7 @@ const noop = () => {};
 /** @typedef {import("webpack").Stats} Stats */
 /** @typedef {import("webpack").MultiStats} MultiStats */
 /** @typedef {import("fs").ReadStream} ReadStream */
-/** @typedef {import("./middleware").Extra} Extra */
+/** @typedef {import("./middleware").FilenameWithExtra} FilenameWithExtra */
 
 // eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {any} EXPECTED_ANY */
@@ -126,7 +126,7 @@ const noop = () => {};
 /**
  * @callback GetFilenameFromUrl
  * @param {string} url request URL
- * @returns {{ filename: string, extra: Extra } | undefined} a filename with additional information, or `undefined` if nothing is found
+ * @returns {Promise<FilenameWithExtra | undefined>} a filename with additional information, or `undefined` if nothing is found
  */
 
 /**

src/middleware.js

@@ -109,9 +109,9 @@ function isNotFoundError(error) {
  * @template {ServerResponse} Response
  * @param {import("./index.js").FilledContext<Request, Response>} context context
  * @param {string} url url
- * @returns {FilenameWithExtra | undefined} result of get filename from url
+ * @returns {Promise<FilenameWithExtra | undefined>} result of get filename from url
  */
-function getFilenameFromUrl(context, url) {
+async function getFilenameFromUrl(context, url) {
   /** @type {URL} */
   let urlObject;
 
@@ -198,9 +198,9 @@ function getFilenameFromUrl(context, url) {
 
       /**
        * @param {string} filename filename
-       * @returns {FilenameWithExtra | undefined} filename when found, otherwise undefined
+       * @returns {Promise<FilenameWithExtra | undefined>} filename when found, otherwise undefined
        */
-      const resolveIndex = (filename) => {
+      const resolveIndex = async (filename) => {
         if (index.length === 0) {
           return;
         }
@@ -234,9 +234,9 @@ function getFilenameFromUrl(context, url) {
 
       /**
        * @param {string} filename filename
-       * @returns {FilenameWithExtra | undefined} filename when found, otherwise undefined
+       * @returns {Promise<FilenameWithExtra | undefined>} filename when found, otherwise undefined
        */
-      const resolveFile = (filename) => {
+      const resolveFile = async (filename) => {
         let stats;
 
         try {
@@ -270,7 +270,7 @@ function getFilenameFromUrl(context, url) {
 
       // send index logic
       if (index.length > 0 && pathname.endsWith("/")) {
-        const result = resolveIndex(filename);
+        const result = await resolveIndex(filename);
 
         if (!result) {
           continue;
@@ -280,7 +280,7 @@ function getFilenameFromUrl(context, url) {
       }
 
       // send file logic
-      const result = resolveFile(filename);
+      const result = await resolveFile(filename);
 
       if (!result) {
         continue;
@@ -771,7 +771,7 @@ function wrapper(context) {
       const requestUrl = /** @type {string} */ (getRequestURL(req));
 
       try {
-        resolved = getFilenameFromUrl(context, requestUrl);
+        resolved = await getFilenameFromUrl(context, requestUrl);
       } catch (err) {
         // Fallback to 403 for unknown errors
         const errorCode =