fix: update redirect logic for URLs ending with '/'

Author: bjohansebas

src/utils/getFilenameFromUrl.js

@@ -50,7 +50,6 @@ class FilenameError extends Error {
   }
 }
 
-// TODO fix redirect logic when `/` at the end, like https://github.com/pillarjs/send/blob/master/index.js#L586
 /**
  * @template {IncomingMessage} Request
  * @template {ServerResponse} Response
@@ -120,6 +119,16 @@ function getFilenameFromUrl(context, url) {
       );
 
       try {
+        if (filename[filename.length - 1] === "/") {
+          if (options.index === false) {
+            return;
+          } else if (options.index === "string") {
+            filename = path.join(filename, options.index);
+          } else {
+            filename = path.join(filename, "index.html");
+          }
+        }
+
         extra.stats = context.outputFileSystem.statSync(filename);
       } catch {
         continue;

test/middleware.test.js

@@ -1736,6 +1736,10 @@ describe.each([
                 value: "noextension",
                 code: 200,
               },
+              {
+                value: "noextension/",
+                code: 404,
+              },
             ],
           },
           {
@@ -1780,6 +1784,11 @@ describe.each([
                 contentType: "text/plain; charset=utf-8",
                 code: 200,
               },
+              {
+                value: "windows%202.txt/",
+                contentType: get404ContentTypeHeader(name),
+                code: 404,
+              },
             ],
           },
           {
@@ -1945,7 +1954,7 @@ describe.each([
 
                   expect(response.statusCode).toEqual(code);
 
-                  if (data) {
+                  if (data && code !== 404) {
                     expect(response.headers["content-length"]).toEqual(
                       String(data.length),
                     );
@@ -5187,6 +5196,15 @@ describe.each([
             "text/html; charset=utf-8",
           );
         });
+
+        it('should return the "404" code for the "GET" request with a non-existent file', async () => {
+          const response = await req.get("/default.html/");
+
+          expect(response.statusCode).toBe(404);
+          expect(response.headers["content-type"]).toBe(
+            get404ContentTypeHeader(name),
+          );
+        });
       });
 
       describe('should work with "string" value with a custom extension', () => {