Skip to content

Commit 0ca8dc2

Browse files
committed
feat: add http2 test for express and remove spdy from app tests
1 parent 873a803 commit 0ca8dc2

1 file changed

Lines changed: 1 addition & 10 deletions

File tree

test/e2e/app.test.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const staticDirectory = path.resolve(
1717
const apps = [
1818
["express", () => require("express")(), "http"],
1919
["express", () => require("express")(), "https"],
20+
["express", () => require("express")(), "http2"],
2021
["connect", () => require("connect")(), "http"],
2122
["connect", () => require("connect")(), "https"],
2223
["connect", () => require("connect")(), "http2"],
@@ -87,15 +88,6 @@ const apps = [
8788
],
8889
];
8990

90-
const [major] = process.versions.node.split(".").map(Number);
91-
92-
if (major < 24) {
93-
apps.push(
94-
["express", () => require("express")(), "spdy"],
95-
["connect", () => require("connect")(), "spdy"],
96-
);
97-
}
98-
9991
describe("app option", () => {
10092
for (const [appName, app, server, setupMiddlewares] of apps) {
10193
let compiler;
@@ -166,7 +158,6 @@ describe("app option", () => {
166158
);
167159

168160
if (
169-
server === "spdy" ||
170161
server === "http2" ||
171162
(server.options && server.options.allowHTTP1)
172163
) {

0 commit comments

Comments
 (0)