-
Notifications
You must be signed in to change notification settings - Fork 9
Expand file tree
/
Copy path.roborev.toml
More file actions
39 lines (32 loc) · 1.93 KB
/
.roborev.toml
File metadata and controls
39 lines (32 loc) · 1.93 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
review_guidelines = """
middleman is a local-first, single-user tool that binds to loopback
(127.0.0.1) by default. There is no multi-user authentication or
session management by design. All API endpoints -- including mutation
endpoints like merge, approve, comment, close, and reopen -- share the
same trust model: the user who started the server is the only intended
consumer.
Do not flag the absence of request-level authentication, authorization,
or CSRF protection on API endpoints. This is an intentional architectural
decision, not a missing feature.
The root-level middleman package (middleman.go) is the embedding API.
It does not have a stable API and can be changed arbitrarily until it
stabilizes. Do not flag breaking changes to its exported surface.
End-to-end tests are non-negotiable in this repository. Major features,
bug fixes, refactors, and user-visible changes affecting API behavior,
data flow, or maintainer workflows require e2e coverage that exercises
the full stack with the real HTTP API and SQLite database.
Treat missing required e2e coverage as at least MEDIUM severity.
Treat it as HIGH severity when the uncovered change affects core
maintainer actions, regression-prone flows, or bug fixes where the lack
of an e2e test could allow a user-visible breakage to ship.
Do not downgrade missing e2e coverage because of a claim that this repo
lacks browser testing infrastructure. middleman already has Playwright
e2e coverage, and many required e2e tests here are API plus SQLite
full-stack tests rather than purely browser concerns.
middleman targets Go 1.26, where the built-in new accepts expression
operands such as new(expr). Do not flag new(expr) usage as invalid,
suspicious, or something that must be rewritten through a temporary
variable solely because older Go versions did not allow it.
Disregard findings whose only substance is that the code does not
compile or type-check. middleman has static tests for that already.
"""