Skip to content

Commit fa3587d

Browse files
committed
Address minor feedback
1 parent fcde77c commit fa3587d

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

examples/attestation/activate_credential.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,13 @@ int TPM2_ActivateCredential_Example(void* userCtx, int argc, char *argv[])
197197
sizeof(activCredIn.credentialBlob.buffer)) {
198198
printf("Credential blob size %d exceeds buffer\n",
199199
activCredIn.credentialBlob.size);
200+
rc = BAD_FUNC_ARG;
200201
goto exit;
201202
}
202203
if (activCredIn.secret.size > sizeof(activCredIn.secret.secret)) {
203204
printf("Secret size %d exceeds buffer\n",
204205
activCredIn.secret.size);
206+
rc = BAD_FUNC_ARG;
205207
goto exit;
206208
}
207209
#else

examples/attestation/make_credential.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ int TPM2_MakeCredential_Example(void* userCtx, int argc, char *argv[])
158158
/* Set the object name */
159159
if (name.size > sizeof(makeCredIn.objectName.name)) {
160160
printf("Name size %d exceeds buffer\n", name.size);
161+
rc = BAD_FUNC_ARG;
161162
goto exit;
162163
}
163164
makeCredIn.objectName.size = name.size;

examples/pcr/extend.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,10 @@ int TPM2_PCR_Extend_Test(void* userCtx, int argc, char *argv[])
163163
XFCLOSE(fp);
164164
if (rc == 0)
165165
rc = wc_HashFinal(&dig, hashType, hash);
166+
if (rc != 0) {
167+
printf("Hash operation failed %d\n", rc);
168+
goto exit;
169+
}
166170

167171
XMEMCPY(cmdIn.pcrExtend.digests.digests[0].digest.H,
168172
hash, hashSz);

src/tpm2_linux.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,14 @@ int TPM2_LINUX_SendCommand(TPM2_CTX* ctx, TPM2_Packet* packet)
146146
}
147147
else {
148148
#ifdef DEBUG_WOLFTPM
149-
printf("Failed to read from %s (ret %zd): errno %d"
150-
" = %s\n", TPM2_LINUX_DEV, ret, errno,
151-
strerror(errno));
149+
if (ret == 0) {
150+
printf("Received EOF from %s\n", TPM2_LINUX_DEV);
151+
}
152+
else {
153+
printf("Failed to read from %s (ret %zd):"
154+
" errno %d = %s\n", TPM2_LINUX_DEV, ret,
155+
errno, strerror(errno));
156+
}
152157
#endif
153158
rc = TPM_RC_FAILURE;
154159
}

0 commit comments

Comments
 (0)