Operator Precedence Bug

ejohnstown · ejohnstown · commit 2da09427cd92 · 2026-03-05T10:43:56.000-08:00
Added parens around an assignment to a variable before it is compared to
an expected value.

Affected function: SetupUserTokenWin.
Issue: F-210
diff --git a/apps/wolfsshd/auth.c b/apps/wolfsshd/auth.c
@@ -915,7 +915,7 @@ static int SetupUserTokenWin(const char* usr,
         authName.Buffer = MSV1_0_PACKAGE_NAME;
         authName.Length = (USHORT)WSTRLEN(MSV1_0_PACKAGE_NAME);
         authName.MaximumLength = authName.Length + 1;
-        if (rc = LsaLookupAuthenticationPackage(lsaHandle, &authName, &authId) != STATUS_SUCCESS) {
+        if ((rc = LsaLookupAuthenticationPackage(lsaHandle, &authName, &authId)) != STATUS_SUCCESS) {
             wolfSSH_Log(WS_LOG_ERROR, "[SSHD] LSA Lookup Authentication Package Error %d", rc);
             ret = WSSHD_AUTH_FAILURE;
         }

Original file line number	Diff line number	Diff line change
`@@ -915,7 +915,7 @@ static int SetupUserTokenWin(const char* usr,`
`915`	`915`	`authName.Buffer = MSV1_0_PACKAGE_NAME;`
`916`	`916`	`authName.Length = (USHORT)WSTRLEN(MSV1_0_PACKAGE_NAME);`
`917`	`917`	`authName.MaximumLength = authName.Length + 1;`
`918`		`- if (rc = LsaLookupAuthenticationPackage(lsaHandle, &authName, &authId) != STATUS_SUCCESS) {`
	`918`	`+ if ((rc = LsaLookupAuthenticationPackage(lsaHandle, &authName, &authId)) != STATUS_SUCCESS) {`
`919`	`919`	`wolfSSH_Log(WS_LOG_ERROR, "[SSHD] LSA Lookup Authentication Package Error %d", rc);`
`920`	`920`	`ret = WSSHD_AUTH_FAILURE;`
`921`	`921`	`}`