Skip to content

Commit f7c8a8e

Browse files
make png unique to PR and fix syntax error
1 parent a53ec96 commit f7c8a8e

1 file changed

Lines changed: 28 additions & 9 deletions

File tree

.github/workflows/sftp-benchmark.yml

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,18 @@ jobs:
7777
run: make
7878

7979
- name: Get Saved OpenSSH Upload Results
80-
uses: actions/downlad-artifact@v4
80+
uses: actions/download-artifact@v4
81+
continue-on-error: true
8182
with:
8283
path: ./wolfssh/
8384
artifact_id: 'openssh-upload'
8485

86+
- name: Get Saved OpenSSH Download Results
87+
uses: actions/download-artifact@v4
88+
continue-on-error: true
89+
with:
90+
path: ./wolfssh/
91+
artifact_id: 'openssh-download'
8592

8693
- name: Put test key in authorized keys file
8794
run: |
@@ -99,24 +106,36 @@ jobs:
99106
- name: Store Upload Speed PNG
100107
uses: actions/upload-artifact@v4
101108
with:
102-
name: upload-results.png
109+
name: upload-results-pr${{ github.event.pull_request.number }}.png
103110
path: wolfssh/upload-results.png
111+
retention-days: 2
104112

105113
- name: Store Download Speed PNG
106114
uses: actions/upload-artifact@v4
107115
with:
108-
name: download-results.png
116+
name: download-results-pr${{ github.event.pull_request.number }}.png
109117
path: wolfssh/download-results.png
118+
retention-days: 2
119+
120+
- name: Upload OpenSSH Download Results
121+
if: steps.download-artifact.outputs.found != 'true'
122+
uses: actions/upload-artifact@v4
123+
with:
124+
name: openssh-download
125+
path: wolfssh/openssh-average-download.csv
126+
127+
- name: Upload OpenSSH Upload Results
128+
if: steps.download-artifact.outputs.found != 'true'
129+
uses: actions/upload-artifact@v4
130+
with:
131+
name: openssh-upload
132+
path: wolfssh/openssh-average-upload.csv
110133

111134
- name: Comment on PR about performance
112135
env:
113136
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
114137
run: |
115138
PR_NUMBER=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")
116139
gh pr comment $PR_NUMBER --body "Attached is the performance results" \
117-
--attach download-results.png \
118-
--attach upload-results.png
119-
120-
artifacts:
121-
'openssh-upload': { 'path': 'wolfssh/openssh-average-upload.csv' }
122-
'openssh-download': { 'path': 'wolfssh/openssh-average-download.csv' }
140+
--attach download-results-pr${{ github.event.pull_request.number }}.png \
141+
--attach upload-results-pr${{ github.event.pull_request.number }}.png

0 commit comments

Comments
 (0)