removed check for n > 0x7fffffff, add negative value check

rlm2002 · rlm2002 · commit 3a0c3a127565 · 2026-02-27T17:26:08.000-07:00
diff --git a/wolfcrypt/src/hpke.c b/wolfcrypt/src/hpke.c
@@ -101,13 +101,13 @@ static int I2OSP(int n, int w, byte* out)
 {
     int i;
 
-    if (w <= 0 || w > 32) {
+    if (w <= 0 || w > 32 || n < 0) {
         return MP_VAL;
     }
 
     /* if width is less than int max check that n is less than w bytes max */
     /* if width is greater than int max check that n is less than int max */
-    if ((w < 4 && n > ((1 << (w * 8)) - 1)) || (w >= 4 && n > 0x7fffffff)) {
+    if ((w < 4 && n > ((1 << (w * 8)) - 1))) {
         return MP_VAL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -101,13 +101,13 @@ static int I2OSP(int n, int w, byte* out)`
`101`	`101`	`{`
`102`	`102`	`int i;`
`103`	`103`
`104`		`- if (w <= 0 \|\| w > 32) {`
	`104`	`+ if (w <= 0 \|\| w > 32 \|\| n < 0) {`
`105`	`105`	`return MP_VAL;`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`/* if width is less than int max check that n is less than w bytes max */`
`109`	`109`	`/* if width is greater than int max check that n is less than int max */`
`110`		`- if ((w < 4 && n > ((1 << (w * 8)) - 1)) \|\| (w >= 4 && n > 0x7fffffff)) {`
	`110`	`+ if ((w < 4 && n > ((1 << (w * 8)) - 1))) {`
`111`	`111`	`return MP_VAL;`
`112`	`112`	`}`
`113`	`113`