CodeQL: o is larger type and could cause issues

SparkiDev · SparkiDev · commit 41eef2ef71ca · 2025-07-04T09:04:39.000+10:00
Make 'o' sp_size_t as the callers are passing 0 or explicit cast to
sp_size_t
diff --git a/wolfcrypt/src/sp_int.c b/wolfcrypt/src/sp_int.c
@@ -7600,7 +7600,7 @@ static void _sp_add_off(const sp_int* a, const sp_int* b, sp_int* r, int o)
  * @param  [in]   o  Number of digits to offset b.
  */
 static void _sp_sub_off(const sp_int* a, const sp_int* b, sp_int* r,
-    unsigned int o)
+    sp_size_t o)
 {
     sp_size_t i = 0;
     sp_size_t j;
@@ -7618,7 +7618,7 @@ static void _sp_sub_off(const sp_int* a, const sp_int* b, sp_int* r,
         }
     }
     else {
-        i = (sp_size_t)o;
+        i = o;
     }
     /* Index to add at is the offset now. */
 

Original file line number	Diff line number	Diff line change
`@@ -7600,7 +7600,7 @@ static void _sp_add_off(const sp_int* a, const sp_int* b, sp_int* r, int o)`
`7600`	`7600`	`* @param [in] o Number of digits to offset b.`
`7601`	`7601`	`*/`
`7602`	`7602`	`static void _sp_sub_off(const sp_int* a, const sp_int* b, sp_int* r,`
`7603`		`- unsigned int o)`
	`7603`	`+ sp_size_t o)`
`7604`	`7604`	`{`
`7605`	`7605`	`sp_size_t i = 0;`
`7606`	`7606`	`sp_size_t j;`
`@@ -7618,7 +7618,7 @@ static void _sp_sub_off(const sp_int* a, const sp_int* b, sp_int* r,`
`7618`	`7618`	`}`
`7619`	`7619`	`}`
`7620`	`7620`	`else {`
`7621`		`- i = (sp_size_t)o;`
	`7621`	`+ i = o;`
`7622`	`7622`	`}`
`7623`	`7623`	`/* Index to add at is the offset now. */`
`7624`	`7624`