Ensure lru_count does not overflow.

kareem-wolfssl · kareem-wolfssl · commit 4bb464828285 · 2026-02-04T15:33:15.000-07:00
diff --git a/wolfcrypt/src/ecc.c b/wolfcrypt/src/ecc.c
@@ -13214,7 +13214,7 @@ int ecc_mul2add(ecc_point* A, mp_int* kA,
             err = add_entry(idx1, A);
          }
       }
-      if (err == MP_OKAY && idx1 != -1) {
+      if (err == MP_OKAY && idx1 != -1 && fp_cache[idx1].lru_count < (INT_MAX-1)) {
          /* increment LRU */
          ++(fp_cache[idx1].lru_count);
       }
@@ -13231,7 +13231,7 @@ int ecc_mul2add(ecc_point* A, mp_int* kA,
          }
       }
 
-      if (err == MP_OKAY && idx2 != -1) {
+      if (err == MP_OKAY && idx2 != -1 && fp_cache[idx2].lru_count < (INT_MAX-1)) {
          /* increment LRU */
          ++(fp_cache[idx2].lru_count);
       }
@@ -13368,7 +13368,7 @@ int wc_ecc_mulmod_ex(const mp_int* k, ecc_point *G, ecc_point *R, mp_int* a,
          if (idx >= 0)
             err = add_entry(idx, G);
       }
-      if (err == MP_OKAY && idx >= 0) {
+      if (err == MP_OKAY && idx >= 0 && fp_cache[idx].lru_count < (INT_MAX-1)) {
          /* increment LRU */
          ++(fp_cache[idx].lru_count);
       }
@@ -13539,7 +13539,7 @@ int wc_ecc_mulmod_ex2(const mp_int* k, ecc_point *G, ecc_point *R, mp_int* a,
          if (idx >= 0)
             err = add_entry(idx, G);
       }
-      if (err == MP_OKAY && idx >= 0) {
+      if (err == MP_OKAY && idx >= 0 && fp_cache[idx].lru_count < (INT_MAX-1)) {
          /* increment LRU */
          ++(fp_cache[idx].lru_count);
       }

Original file line number	Diff line number	Diff line change
`@@ -13214,7 +13214,7 @@ int ecc_mul2add(ecc_point* A, mp_int* kA,`
`13214`	`13214`	`err = add_entry(idx1, A);`
`13215`	`13215`	`}`
`13216`	`13216`	`}`
`13217`		`- if (err == MP_OKAY && idx1 != -1) {`
	`13217`	`+ if (err == MP_OKAY && idx1 != -1 && fp_cache[idx1].lru_count < (INT_MAX-1)) {`
`13218`	`13218`	`/* increment LRU */`
`13219`	`13219`	`++(fp_cache[idx1].lru_count);`
`13220`	`13220`	`}`
`@@ -13231,7 +13231,7 @@ int ecc_mul2add(ecc_point* A, mp_int* kA,`
`13231`	`13231`	`}`
`13232`	`13232`	`}`
`13233`	`13233`
`13234`		`- if (err == MP_OKAY && idx2 != -1) {`
	`13234`	`+ if (err == MP_OKAY && idx2 != -1 && fp_cache[idx2].lru_count < (INT_MAX-1)) {`
`13235`	`13235`	`/* increment LRU */`
`13236`	`13236`	`++(fp_cache[idx2].lru_count);`
`13237`	`13237`	`}`
`@@ -13368,7 +13368,7 @@ int wc_ecc_mulmod_ex(const mp_int* k, ecc_point G, ecc_point R, mp_int* a,`
`13368`	`13368`	`if (idx >= 0)`
`13369`	`13369`	`err = add_entry(idx, G);`
`13370`	`13370`	`}`
`13371`		`- if (err == MP_OKAY && idx >= 0) {`
	`13371`	`+ if (err == MP_OKAY && idx >= 0 && fp_cache[idx].lru_count < (INT_MAX-1)) {`
`13372`	`13372`	`/* increment LRU */`
`13373`	`13373`	`++(fp_cache[idx].lru_count);`
`13374`	`13374`	`}`
`@@ -13539,7 +13539,7 @@ int wc_ecc_mulmod_ex2(const mp_int* k, ecc_point G, ecc_point R, mp_int* a,`
`13539`	`13539`	`if (idx >= 0)`
`13540`	`13540`	`err = add_entry(idx, G);`
`13541`	`13541`	`}`
`13542`		`- if (err == MP_OKAY && idx >= 0) {`
	`13542`	`+ if (err == MP_OKAY && idx >= 0 && fp_cache[idx].lru_count < (INT_MAX-1)) {`
`13543`	`13543`	`/* increment LRU */`
`13544`	`13544`	`++(fp_cache[idx].lru_count);`
`13545`	`13545`	`}`