Fix from review

embhorn · embhorn · commit 6f888d2d8fc3 · 2026-04-27T15:32:25.000-05:00
diff --git a/src/tls.c b/src/tls.c
@@ -10236,11 +10236,7 @@ static int TLSX_KeyShare_ProcessPqcHybridClient(WOLFSSL* ssl,
     }
 
     if (ret == 0) {
-        keyShareEntry->key = ecc_kse->key;
-        ecc_kse->key = NULL;
-
-        if ((ret == 0) &&
-            ((ssl->arrays->preMasterSz + ssSzPqc) > ENCRYPT_LEN)) {
+        if ((ssl->arrays->preMasterSz + ssSzPqc) > ENCRYPT_LEN) {
             WOLFSSL_MSG("shared secret is too long.");
             ret = LENGTH_ERROR;
         }

Original file line number	Diff line number	Diff line change
`@@ -10236,11 +10236,7 @@ static int TLSX_KeyShare_ProcessPqcHybridClient(WOLFSSL* ssl,`
`10236`	`10236`	`}`
`10237`	`10237`
`10238`	`10238`	`if (ret == 0) {`
`10239`		`- keyShareEntry->key = ecc_kse->key;`
`10240`		`- ecc_kse->key = NULL;`
`10241`		`-`
`10242`		`- if ((ret == 0) &&`
`10243`		`- ((ssl->arrays->preMasterSz + ssSzPqc) > ENCRYPT_LEN)) {`
	`10239`	`+ if ((ssl->arrays->preMasterSz + ssSzPqc) > ENCRYPT_LEN) {`
`10244`	`10240`	`WOLFSSL_MSG("shared secret is too long.");`
`10245`	`10241`	`ret = LENGTH_ERROR;`
`10246`	`10242`	`}`