Skip to content

Commit cbd1244

Browse files
Code review feedback
1 parent e092484 commit cbd1244

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

wolfcrypt/src/pkcs7.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2256,7 +2256,7 @@ static int wc_PKCS7_BuildSignedAttributes(wc_PKCS7* pkcs7, ESD* esd,
22562256
esd->signedAttribsCount += idx;
22572257
esd->signedAttribsSz += (word32)EncodeAttributes(
22582258
&esd->signedAttribs[atrIdx], (int)idx, cannedAttribs,
2259-
(int)cannedAttribsCount);
2259+
(int)idx);
22602260
atrIdx += idx;
22612261
} else {
22622262
esd->signedAttribsCount = 0;
@@ -13231,7 +13231,9 @@ int wc_PKCS7_DecodeEnvelopedData(wc_PKCS7* pkcs7, byte* in,
1323113231
}
1323213232
wc_PKCS7_DecryptContentFree(pkcs7, encOID, pkcs7->heap);
1323313233
} else {
13234-
if ((idx + (word32)encryptedContentTotalSz) > pkiMsgSz) {
13234+
word32 tmpSum;
13235+
if (!WC_SAFE_SUM_WORD32(idx, (word32)encryptedContentTotalSz, tmpSum) ||
13236+
tmpSum > pkiMsgSz) {
1323513237
ret = BUFFER_E;
1323613238
break;
1323713239
}

0 commit comments

Comments
 (0)