Skip to content

Commit eff2fcd

Browse files
committed
scripts/pem.test: refactor to eliminate dependence on bash [[ -v foo ]] construct.
1 parent 8b67392 commit eff2fcd

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

scripts/pem.test

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ if grep -q -E '^#define OPENSSL_EXTRA$' wolfssl/options.h; then
7373
OPENSSL_EXTRA=1
7474
fi
7575

76-
if [[ ! -v WOLFSSL_KEY_GEN && ! -v WOLFSSL_CERT_GEN && ! -v OPENSSL_EXTRA ]]; then
76+
if [ "$WOLFSSL_KEY_GEN" != 1 ] && [ "$WOLFSSL_CERT_GEN" != 1 ] && [ "$OPENSSL_EXTRA" != 1 ]; then
7777
WOLFSSL_NO_DER_TO_PEM=1
7878
fi
7979

@@ -85,12 +85,12 @@ if grep -q -E '^#define NO_CODING$' wolfssl/options.h; then
8585
NO_CODING=1
8686
fi
8787

88-
if [[ -v WOLFSSL_NO_PEM ]]; then
88+
if [ "$WOLFSSL_NO_PEM" = 1 ]; then
8989
echo "WOLFSSL_NO_PEM is configured -- skipping pem.test."
9090
exit 77
9191
fi
9292

93-
if [[ -v NO_CODING ]]; then
93+
if [ "$NO_CODING" = 1 ]; then
9494
echo "NO_CODING is configured -- skipping pem.test."
9595
exit 77
9696
fi
@@ -255,7 +255,7 @@ compare_der() {
255255
#
256256
# @param [in] $* Command line parameters to pem example.
257257
convert_to_pem() {
258-
if [[ -v WOLFSSL_NO_DER_TO_PEM ]]; then
258+
if [ "$WOLFSSL_NO_DER_TO_PEM" = 1 ]; then
259259
echo ' Skipping -- WOLFSSL_NO_DER_TO_PEM'
260260
TEST_SKIP_CNT=$((TEST_SKIP_CNT+1))
261261
return 0
@@ -289,7 +289,7 @@ compare_pem() {
289289
# @param [in] $3 PEM type expected in PEM file and to place in created PEM
290290
# file.
291291
pem_der_exp() {
292-
if [[ -v WOLFSSL_NO_DER_TO_PEM ]]; then
292+
if [ "$WOLFSSL_NO_DER_TO_PEM" = 1 ]; then
293293
echo ' Skipping -- WOLFSSL_NO_DER_TO_PEM'
294294
TEST_SKIP_CNT=$((TEST_SKIP_CNT+1))
295295
return 0
@@ -324,7 +324,7 @@ pem_der_exp() {
324324
#
325325
# @param [in] $@ Command line parameters to pem example when encrypting.
326326
der_pem_enc() {
327-
if [[ -v WOLFSSL_NO_DER_TO_PEM ]]; then
327+
if [ "$WOLFSSL_NO_DER_TO_PEM" = 1 ]; then
328328
echo ' Skipping -- WOLFSSL_NO_DER_TO_PEM'
329329
TEST_SKIP_CNT=$((TEST_SKIP_CNT+1))
330330
return 0
@@ -458,14 +458,14 @@ pem_der_exp ./certs/csr.dsa.pem \
458458
# pem_der_exp ./certs/crl/caEccCrl.pem \
459459
# ./certs/crl/caEccCrl.der 'X509 CRL'
460460

461-
if [[ ! -v HAVE_FIPS ]]; then
462-
if [[ -v HAVE_DES3 && -v HAVE_RSA ]]; then
461+
if [ "$HAVE_FIPS" != 1 ]; then
462+
if [ "$HAVE_DES3" = 1 ] && [ "$HAVE_RSA" = 1 ]; then
463463
USAGE_STRING=$ENC_STRING
464464
test_setup "Encrypted Key with header"
465465
convert_to_der -in ./certs/server-keyEnc.pem -p yassl123 --padding
466466
fi
467467

468-
if [[ -v HAVE_DES3 && -v HAVE_MD5 && -v HAVE_RSA ]]; then
468+
if [ "$HAVE_DES3" = 1 ] && [ "$HAVE_MD5" = 1 ] && [ "$HAVE_RSA" = 1 ]; then
469469
USAGE_STRING=$ENC_STRING
470470
test_setup "Encrypted Key - PKCS#8"
471471
convert_to_der -in ./certs/server-keyPkcs8Enc.pem -p yassl123
@@ -475,13 +475,13 @@ if [[ ! -v HAVE_FIPS ]]; then
475475
convert_to_der -in ./certs/server-keyPkcs8Enc12.pem -p yassl123
476476
fi
477477

478-
if [[ -v HAVE_MD5 && -v HAVE_DES3 ]]; then
478+
if [ "$HAVE_MD5" = 1 ] && [ "$HAVE_DES3" = 1 ]; then
479479
USAGE_STRING="PBES1_MD5_DES"
480480
test_setup "Encrypted Key - PKCS#8 (PKCS#5 PBES1-MD5-DES)"
481481
convert_to_der -in ./certs/ecc-keyPkcs8Enc.pem -p yassl123
482482
fi
483483

484-
if [[ -v HAVE_SHA && -v HAVE_DES3 ]]; then
484+
if [ "$HAVE_SHA" = 1 ] && [ "$HAVE_DES3" = 1 ]; then
485485
USAGE_STRING=" DES3"
486486
test_setup "Encrypted Key - PKCS#8 (PKCS#5v2 PBE-SHA1-DES3)"
487487
convert_to_der -in ./certs/server-keyPkcs8Enc2.pem -p yassl123
@@ -525,15 +525,15 @@ fi
525525
# test_setup "Encrypt Key - PKCS#8 (PKCS#5 PBES2 DES3)"
526526
# der_pem_enc --pbe-alg DES3
527527

528-
if [[ ! -v HAVE_FIPS ]]; then
529-
if [[ -v HAVE_MD5 && -v HAVE_DES3 ]]; then
528+
if [ "$HAVE_FIPS" = 1 ]; then
529+
if [ "$HAVE_MD5" = 1 ] && [ "$HAVE_DES3" = 1 ]; then
530530
USAGE_STRING="PBES1_MD5_DES"
531531
PEM_TYPE="ENCRYPTED PRIVATE KEY"
532532
test_setup "Encrypt Key - PKCS#8 (PKCS#5 PBES1-MD5-DES)"
533533
der_pem_enc --pbe PBES1_MD5_DES
534534
fi
535535

536-
if [[ -v HAVE_SHA && -v HAVE_DES3 ]]; then
536+
if [ "$HAVE_SHA" = 1 ] && [ "$HAVE_DES3" = 1 ]; then
537537
USAGE_STRING="PBES1_SHA1_DES"
538538
PEM_TYPE="ENCRYPTED PRIVATE KEY"
539539
test_setup "Encrypt Key - PKCS#8 (PKCS#5 PBES1-SHA1-DES)"
@@ -545,14 +545,14 @@ if [[ ! -v HAVE_FIPS ]]; then
545545
der_pem_enc --pbe-ver PKCS12 --pbe SHA1_DES3
546546
fi
547547

548-
if [[ -v HAVE_SHA && -v HAVE_RC4 ]]; then
548+
if [ "$HAVE_SHA" = 1 ] && [ "$HAVE_RC4" = 1 ]; then
549549
USAGE_STRING=" SHA1_RC4_128"
550550
PEM_TYPE="ENCRYPTED PRIVATE KEY"
551551
test_setup "Encrypt Key - PKCS#8 (PKCS#12 PBE-SHA1-RC4-128)"
552552
der_pem_enc --pbe-ver PKCS12 --pbe SHA1_RC4_128
553553
fi
554554

555-
if [[ -v HAVE_SHA && -v HAVE_RC2 ]]; then
555+
if [ "$HAVE_SHA" = 1 ] && [ "$HAVE_RC2" = 1 ]; then
556556
USAGE_STRING="SHA1_40RC2_CBC"
557557
PEM_TYPE="ENCRYPTED PRIVATE KEY"
558558
test_setup "Encrypt Key - PKCS#8 (PKCS#12 PBE-SHA1-40RC2-CBC)"

0 commit comments

Comments
 (0)