Skip to content

Commit 751ca6e

Browse files
committed
fix missing Javadoc warnings in ALPN additions
1 parent c06c714 commit 751ca6e

3 files changed

Lines changed: 25 additions & 4 deletions

File tree

src/java/com/wolfssl/WolfSSL.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,13 @@ public static enum TLS_VERSION {
187187
public final static int WOLFSSL_OCSP_NO_NONCE = 2;
188188

189189
/* ALPN definitions from ssl.h */
190+
/** ALPN: no match found */
190191
public final static int WOLFSSL_ALPN_NO_MATCH = 0;
192+
/** ALPN: found match */
191193
public final static int WOLFSSL_ALPN_MATCH = 1;
194+
/** ALPN: continue on protocol mismatch */
192195
public final static int WOLFSSL_ALPN_CONTINUE_ON_MISMATCH = 2;
196+
/** ALPN: failed on protocol mismatch */
193197
public final static int WOLFSSL_ALPN_FAILED_ON_MISMATCH = 4;
194198

195199
/* I/O callback default errors, pulled from wolfssl/ssl.h IOerrors */

src/java/com/wolfssl/provider/jsse/WolfSSLEngineHelper.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,12 @@ protected byte[] getAlpnSelectedProtocol() {
370370
return null;
371371
}
372372

373+
/**
374+
* Get selected ALPN protocol string
375+
*
376+
* @return String representation of selected ALPN protocol or null
377+
* if handshake has not finished
378+
*/
373379
protected String getAlpnSelectedProtocolString() {
374380
if (ssl.handshakeDone()) {
375381
String proto = ssl.getAlpnSelectedString();

src/java/com/wolfssl/provider/jsse/adapter/WolfSSLJDK8Helper.java

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,14 @@ protected static void getServerNames(final SSLParameters in,
110110
}
111111
}
112112

113-
/* Call SSLParameters.setApplicationProtocols() to set ALPN protocols from
114-
* WolfSSLParameters into SSLParameters */
113+
/**
114+
* Call SSLParameters.setApplicationProtocols() to set ALPN protocols from
115+
* WolfSSLParameters into SSLParameters.
116+
*
117+
* @param out output SSLParameters to store ALPN protocols into
118+
* @param m method to invoke to set protocols
119+
* @param in input WolfSSLParameters to read ALPN protocols from
120+
*/
115121
protected static void setApplicationProtocols(final SSLParameters out,
116122
final Method m, WolfSSLParameters in) {
117123

@@ -137,8 +143,13 @@ public Object run() {
137143
}
138144
}
139145

140-
/* Call SSLParameters.getApplicationProtocols() to get ALPN protocols from
141-
* SSLParameters into WolfSSLParameters */
146+
/**
147+
* Call SSLParameters.getApplicationProtocols() to get ALPN protocols from
148+
* SSLParameters into WolfSSLParameters.
149+
*
150+
* @param in input SSLParameters to read ALPN protocols from
151+
* @param out output WolfSSLParameters to store ALPN protocols into
152+
*/
142153
protected static void getApplicationProtocols(final SSLParameters in,
143154
WolfSSLParameters out) {
144155

0 commit comments

Comments
 (0)