Commit d8b9d2e
authored
* fix[faustwp-cli]: (#1850) detect HTTP Basic Auth and show accurate error
When a WordPress site is protected with HTTP Basic Authentication,
the secret key validation request returns 401 from the web server,
not from FaustWP. The health check assumed any 401 meant the secret
key was wrong, showing a misleading error message.
Check the WWW-Authenticate response header for "Basic" to distinguish
HTTP Basic Auth (web server) from a secret key mismatch (plugin).
Show a specific error message telling the user their site has Basic
Auth protection.
Closes #1850
* fix[faustwp-cli]: move Basic Auth test inside describe block and format
---------
Co-authored-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
1 parent de53f5c commit d8b9d2e
File tree
3 files changed
+52
-4
lines changed- .changeset
- packages/faustwp-cli
- src/healthCheck
- tests/healthCheck
3 files changed
+52
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
65 | 74 | | |
66 | 75 | | |
67 | 76 | | |
| |||
Lines changed: 34 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
74 | 108 | | |
75 | 109 | | |
76 | 110 | | |
| |||
0 commit comments