fix: reading proof values in chunk aggregator

Author: MarcosNicolau

aggregation_mode/proof_aggregator/aggregation_programs/zisk/elf/zisk_chunk_aggregator_program

@@ -6,10 +6,10 @@ use zisk_aggregation_program::{ChunkAggregatorInput, Hash32};
 
 // Generated with `make proof_aggregator_write_program_ids` and copied from program_ids.json
 pub const USER_PROOFS_AGGREGATOR_PROGRAM_ROM_ROOT: [u64; 4] = [
-    9552917093105913802,
-    7845128850459495418,
-    6121665346010988278,
-    15056293071596476132,
+    8006415978237093766,
+    9267864536843082901,
+    14454613831466088168,
+    10034785771278346133,
 ];
 
 pub fn main() {
@@ -23,22 +23,25 @@ pub fn main() {
         let proof_words = bytemuck::cast_slice::<u8, u64>(&proof.proof);
 
         // Reading public inputs as done in the verify of the lib at https://github.com/0xPolygonHermez/zisk/blob/maint/checkouts/pil2-proofman-3d49384e4e2f0af7/78497c5/verifier/src/verifier.rs#L66-L73
-        let mut p = 0;
-        let n_public_inputs = proof_words[p];
-        p += 1;
 
-        // we should end up with a vector of length 4 as the public input is a 256 bits digest
+        // First 64 bits are the length of public outputs so we skip it
+        let mut proof_idx = 1;
+
+        // Next 4 entries are the program rom-key
         let mut rom_vkey: [u64; 4] = [0_u64; 4];
+        for i in 0..4 {
+            rom_vkey[i as usize] = proof_words[proof_idx];
+            proof_idx += 1;
+        }
+
+        // Next entry is the number of public inputs set by the program with 'ziskos::set_output'
+        // we should end up with a vector of length 4 as the public input is a 256 bits digest
         let mut publics = Vec::new();
-        for i in 0..n_public_inputs {
-            // The first 4 entries are the rom vkey
-            if i < 4 {
-                rom_vkey[i as usize] = proof_words[p];
-                p += 1;
-            }
-
-            publics.push(proof_words[p]);
-            p += 1;
+        let n_public_inputs = proof_words[proof_idx];
+        proof_idx += 1;
+        for _ in 0..n_public_inputs {
+            publics.push(proof_words[proof_idx]);
+            proof_idx += 1;
         }
 
         // Ensure the aggregated chunk originates from the user proofs aggregation program.

aggregation_mode/proof_aggregator/aggregation_programs/zisk/src/chunk_aggregator_main.rs

@@ -1 +1 @@
-��^����2�i��Ob�o�'[5�����}�w
+,�~�~���������(�L�$ܤ�l���

aggregation_mode/proof_aggregator/aggregation_programs/zisk/vk/zisk_chunk_aggregator_program

@@ -5,6 +5,6 @@
   "sp1_chunk_aggregator_vk_hash": "0x00d6e32a34f68ea643362b96615591c94ee0bf99ee871740ab2337966a4f77af",
   "sp1_user_proofs_aggregator_vk_hash": "0x00a0fe3e73d4dd5f66369c60629213c8a037da04f8f68724c8a15ed1d20a0d5e",
   "sp1_user_proofs_aggregator_vk_hash_words": "[1350508345, 1966561241, 1188269068, 690044042, 29282343, 1675238547, 289586595, 1376390494]",
-  "zisk_chunk_aggregator_rom_vk_hex": "0xfd518d50ee1b5bfe9e594448582fc8556b7313e2607e3d1f10a1d475800912b0",
-  "zisk_user_proofs_aggregator_rom_vk": "[9552917093105913802, 7845128850459495418, 6121665346010988278, 15056293071596476132]"
+  "zisk_chunk_aggregator_rom_vk_hex": "0x2ce6917eec7ea5abcbc4cef57f0ca21414bc8f28e04c9d24dca4b96ca98c16f2",
+  "zisk_user_proofs_aggregator_rom_vk": "[8006415978237093766, 9267864536843082901, 14454613831466088168, 10034785771278346133]"
 }

aggregation_mode/proof_aggregator/programs_ids.json

@@ -181,6 +181,7 @@ pub(crate) fn run_chunk_aggregator(
             INPUT_PATH,
             "-o",
             OUTPUT_PATH,
+            "-u",
             "-a",
             "-y",
             "-f",